From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2999C4727D for ; Fri, 2 Oct 2020 14:32:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1DCA206A5 for ; Fri, 2 Oct 2020 14:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="oE/gIV82" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1DCA206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOM6S-0006zS-0p for qemu-devel@archiver.kernel.org; Fri, 02 Oct 2020 10:32:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOM4k-0005mJ-DX for qemu-devel@nongnu.org; Fri, 02 Oct 2020 10:30:22 -0400 Received: from lizzy.crudebyte.com ([91.194.90.13]:41165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOM4i-0002v2-3s for qemu-devel@nongnu.org; Fri, 02 Oct 2020 10:30:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=zL3ZhINMzah40/bysuxOXwjKOBsEBq0Tg8PA6cHlV48=; b=oE/gIV82gHZihhjXvmidNfq6Dq sNRQPJu5cwsCtkbCWZurtEjIwV4l7SuMMpxOJmapzlwzIxtM0oJtCN14YygG1GkRaMXS6jESaKzw+ ev30yp0dfymqXnfWzaigDC0+SBUH/oKPXryOIIAp9TQY7+Y8uGbYE8iPcODvXdeZav7DcDTV/BYLR 9qkrA5OQfWhN+DiRw8WhYYhkk0NlHV8kmnJXI21dN2eDKoHcB8ONnnrovHXFsNs3BTFmDEXUvjCnd 7DOnOaDE0AGY0BoJ5nYUK8sROmnku6hB1MunMnypsDw/Rw+G3vKSvbVMr4Xia2MqMSjzvRYjkKD8k 1ScidkeA==; From: Christian Schoenebeck To: Daniel =?ISO-8859-1?Q?P=2E_Berrang=E9?= Cc: qemu-devel@nongnu.org, Laurent Vivier , Thomas Huth , Emanuele Giuseppe Esposito , Greg Kurz , Paolo Bonzini Subject: Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test Date: Fri, 02 Oct 2020 16:30:17 +0200 Message-ID: <6486076.Ap9L6znzn6@silver> In-Reply-To: <20201002142331.GF2338114@redhat.com> References: <2008745.A24TOvDVlx@silver> <20201002142331.GF2338114@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Received-SPF: pass client-ip=91.194.90.13; envelope-from=qemu_oss@crudebyte.com; helo=lizzy.crudebyte.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 08:18:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Freitag, 2. Oktober 2020 16:23:31 CEST Daniel P. Berrang=E9 wrote: > No need to realloate a new array - just shuffle down the elements in > the array you get back from g_strsplit to discard the empty ones. Sure > the array will end up with a series of NULLs at the end but that is > harmless. >=20 > both g_strsplit/g_strfreev work in terms of a normal allocated "char **" > array, so there's no risk of changes to way memory is allocated. Ok then, if you say so ... fine with me. Best regards, Christian Schoenebeck