Re: [PATCH 07/13] hw/arm/fsl-imx8mm: Adding support for I2C emulation

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 10/11/25 12:22, Gaurav Sharma wrote:
> This can be used to test and debug I2C device drivers.
> Added I2C interrupts
> 
> Signed-off-by: Gaurav Sharma <gaurav.sharma_7@nxp.com>
> ---
>   docs/system/arm/imx8mm-evk.rst |  1 +
>   hw/arm/Kconfig                 |  2 ++
>   hw/arm/fsl-imx8mm.c            | 27 +++++++++++++++++++++++++++
>   include/hw/arm/fsl-imx8mm.h    |  8 ++++++++
>   4 files changed, 38 insertions(+)


> diff --git a/hw/arm/fsl-imx8mm.c b/hw/arm/fsl-imx8mm.c
> index 222d3bac1c..eaa9a66efc 100644
> --- a/hw/arm/fsl-imx8mm.c
> +++ b/hw/arm/fsl-imx8mm.c
> @@ -177,6 +177,11 @@ static void fsl_imx8mm_init(Object *obj)
>           object_initialize_child(obj, name, &s->uart[i], TYPE_IMX_SERIAL);
>       }
>   
> +    for (i = 0; i < FSL_IMX8MM_NUM_I2CS; i++) {
> +        g_autofree char *name = g_strdup_printf("i2c%d", i + 1);
> +        object_initialize_child(obj, name, &s->i2c[i], TYPE_IMX_I2C);
> +    }
> +
>       for (i = 0; i < FSL_IMX8MM_NUM_GPIOS; i++) {
>           g_autofree char *name = g_strdup_printf("gpio%d", i + 1);
>           object_initialize_child(obj, name, &s->gpio[i], TYPE_IMX_GPIO);
> @@ -355,6 +360,27 @@ static void fsl_imx8mm_realize(DeviceState *dev, Error **errp)
>                              qdev_get_gpio_in(gicdev, serial_table[i].irq));
>       }
>   
> +    /* I2Cs */
> +    for (i = 0; i < FSL_IMX8MM_NUM_I2CS; i++) {

static const?

> +        struct {
> +            hwaddr addr;
> +            unsigned int irq;
> +        } i2c_table[FSL_IMX8MM_NUM_I2CS] = {
> +            { fsl_imx8mm_memmap[FSL_IMX8MM_I2C1].addr, FSL_IMX8MM_I2C1_IRQ },
> +            { fsl_imx8mm_memmap[FSL_IMX8MM_I2C2].addr, FSL_IMX8MM_I2C2_IRQ },
> +            { fsl_imx8mm_memmap[FSL_IMX8MM_I2C3].addr, FSL_IMX8MM_I2C3_IRQ },
> +            { fsl_imx8mm_memmap[FSL_IMX8MM_I2C4].addr, FSL_IMX8MM_I2C4_IRQ },
> +        };
> +
> +        if (!sysbus_realize(SYS_BUS_DEVICE(&s->i2c[i]), errp)) {
> +            return;
> +        }
> +
> +        sysbus_mmio_map(SYS_BUS_DEVICE(&s->i2c[i]), 0, i2c_table[i].addr);
> +        sysbus_connect_irq(SYS_BUS_DEVICE(&s->i2c[i]), 0,
> +                           qdev_get_gpio_in(gicdev, i2c_table[i].irq));
> +    }

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>