From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] target/s390x: Improve cc computation for ADD LOGICAL
Date: Tue, 20 Oct 2020 16:08:24 +0200 [thread overview]
Message-ID: <649e2a34-6ef1-1be2-321c-bfeb050b90b5@redhat.com> (raw)
In-Reply-To: <20201017022901.78425-2-richard.henderson@linaro.org>
On 17.10.20 04:28, Richard Henderson wrote:
> The resulting cc is only dependent on the result and the
> carry-out. So save those things rather than the inputs.
>
> Carry-out for 64-bit inputs is had via tcg_gen_add2_i64 directly
> into cc_src. Carry-out for 32-bit inputs is had via extraction
> from a normal 64-bit add (with zero-extended inputs).
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
LGTM
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-10-20 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 2:28 [PATCH 0/4] target/s390x: Improve carry computation Richard Henderson
2020-10-17 2:28 ` [PATCH 1/4] target/s390x: Improve cc computation for ADD LOGICAL Richard Henderson
2020-10-20 14:08 ` David Hildenbrand [this message]
2020-10-17 2:28 ` [PATCH 2/4] target/s390x: Improve ADD LOGICAL WITH CARRY Richard Henderson
2020-10-20 14:12 ` David Hildenbrand
2020-10-17 2:29 ` [PATCH 3/4] target/s390x: Improve cc computation for SUBTRACT LOGICAL Richard Henderson
2020-10-20 14:14 ` David Hildenbrand
2020-10-17 2:29 ` [PATCH 4/4] target/s390x: Improve SUB LOGICAL WITH BORROW Richard Henderson
2020-10-20 14:17 ` David Hildenbrand
2020-10-20 15:11 ` Richard Henderson
2020-10-20 15:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649e2a34-6ef1-1be2-321c-bfeb050b90b5@redhat.com \
--to=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).