qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre DERUMIER <aderumier@odiso.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com,
	qemu-devel@nongnu.org, Dietmar Maurer <dietmar@proxmox.com>,
	agl@us.ibm.com
Subject: Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats
Date: Mon, 10 Dec 2012 08:52:52 +0100 (CET)	[thread overview]
Message-ID: <649ea166-fa62-48e4-8954-f37b34b91b1b@mailpro> (raw)
In-Reply-To: <20121207165444.163bbb4f@doriath.home>

>>That's kernel work, qemu is merely reporting what the kernel is making
>>available. But giving that you'll touch the kernel anyway, it's better
>>to add a new stat.
>>
>>There are two other alternatives:
>>
>>1. add a query-memory-stats command to qemu-ga
>>
>>Pros: should be quicker and easier to modify/extend
>>Cons: has the implications of running this from the guest user-space

Hello,
I would like also extend balloon stats to retrieve guest buffer memory, It can help a lot for doing accurate balloning.

Using qemu-ga is easy for linux (we can read /proc/meminfo), but with windows guest is impossible currently.
(we need to query wmi counter, and executing process is no possible with qga)
Adding the new wmi counter ("System Cache Resident Bytes") is quite easy in windows balloon driver.

Best Regards,

Alexandre Derumier


--- Mail original -----

De: "Luiz Capitulino" <lcapitulino@redhat.com>
À: "Dietmar Maurer" <dietmar@proxmox.com>
Cc: aliguori@us.ibm.com, agl@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Envoyé: Vendredi 7 Décembre 2012 19:54:44
Objet: Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

On Fri, 7 Dec 2012 15:01:36 +0000
Dietmar Maurer <dietmar@proxmox.com> wrote:

> > > Is it possible to extent those statistic to include buffer/cache values?
> >
> > Yes, should be possible but the kernel virtio-balloon driver has to be 
> > extended too (and I suspect this kind of change goes into the kernel first).
>
> The current statistics are quite useless without that information, and

Maybe it's not possible to implement the feature you want to implement, but
I do get a ping once a while from people asking for these stats. Some of them
are people running virsh dommemstat which also makes use of that information.

> I guess it is impossible to such changes upstream within a reasonable time?

In the kernel, yes it would take a while.

> So what is the purpose of that 'stat-free-memory'? Can we change that to 
> return the amount of free RAM including buffers?

That's kernel work, qemu is merely reporting what the kernel is making
available. But giving that you'll touch the kernel anyway, it's better
to add a new stat.

There are two other alternatives:

1. add a query-memory-stats command to qemu-ga

Pros: should be quicker and easier to modify/extend
Cons: has the implications of running this from the guest user-space

2. wait for the (kernel-based) auto-ballooning feature, which is on the
works

Pros: you do nothing and it's going to be completely automatic
Cons: this is unlikely to be ready for the short term

      parent reply	other threads:[~2012-12-10  7:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 15:04 [Qemu-devel] [RFC 0/3] re-enable balloon stats Luiz Capitulino
2012-12-04 15:04 ` [Qemu-devel] [RFC 1/3] virtio-balloon: drop old stats code Luiz Capitulino
2012-12-04 15:04 ` [Qemu-devel] [RFC 2/3] virtio-balloon: re-enable balloon stats Luiz Capitulino
2012-12-06 17:03   ` mdroth
2012-12-06 17:58     ` Luiz Capitulino
2012-12-04 15:04 ` [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats Luiz Capitulino
2012-12-06 13:24   ` Daniel P. Berrange
2012-12-06 15:31     ` Luiz Capitulino
2012-12-06 16:59       ` mdroth
2012-12-07  5:30   ` Dietmar Maurer
2012-12-07 12:23     ` Luiz Capitulino
2012-12-07 15:01       ` Dietmar Maurer
2012-12-07 18:54         ` Luiz Capitulino
2012-12-08  6:26           ` Dietmar Maurer
2012-12-10 11:19             ` Luiz Capitulino
2012-12-10 12:06               ` Dietmar Maurer
2012-12-10  7:52           ` Alexandre DERUMIER [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=649ea166-fa62-48e4-8954-f37b34b91b1b@mailpro \
    --to=aderumier@odiso.com \
    --cc=agl@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=dietmar@proxmox.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).