From: Eric Blake <eblake@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] block/replication: Clarify 'top-id' parameter usage
Date: Tue, 11 Oct 2016 09:54:25 -0500 [thread overview]
Message-ID: <64a8b1be-9165-c0ab-fcaa-7c7e75dec479@redhat.com> (raw)
In-Reply-To: <1476182772-11693-3-git-send-email-xiecl.fnst@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On 10/11/2016 05:46 AM, Changlong Xie wrote:
> Replication driver only support 'top-id' parameter in secondary side,
> and it must not be supplied in primary side
Grammar suggestion:
The replication driver only supports the 'top-id' parameter for the
secondary side; it must not be supplied for the primary side.
>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
> block/replication.c | 5 +++++
> qapi/block-core.json | 3 ++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-10-11 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 10:46 [Qemu-devel] [PATCH v2 0/2] block/replication fixes Changlong Xie
2016-10-11 10:46 ` [Qemu-devel] [PATCH v2 1/2] block/replication: prefect the logic to acquire 'top_id' Changlong Xie
2016-10-11 14:52 ` Eric Blake
2016-10-12 0:40 ` Changlong Xie
2016-10-11 10:46 ` [Qemu-devel] [PATCH v2 2/2] block/replication: Clarify 'top-id' parameter usage Changlong Xie
2016-10-11 14:54 ` Eric Blake [this message]
2016-10-12 0:41 ` Changlong Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64a8b1be-9165-c0ab-fcaa-7c7e75dec479@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).