From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
berrange@redhat.com, stefanb@linux.vnet.ibm.com, f4bug@amsat.org,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, aurelien@aurel32.net
Subject: Re: [PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic
Date: Thu, 3 Sep 2020 10:16:38 -0700 [thread overview]
Message-ID: <64aaeb37-04fd-d57d-3c1b-3a8d70ec9f2a@linaro.org> (raw)
In-Reply-To: <20200903112107.27367-8-alex.bennee@linaro.org>
On 9/3/20 4:21 AM, Alex Bennée wrote:
> One of the Travis builds was complaining about:
>
> qemu/include/tcg/tcg.h:437:12: error: ‘cond’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> return (TCGCond)(c ^ 1);
> ../target/mips/translate.c:20031:13: note: ‘cond’ was declared here
> TCGCond cond;
>
> Rather than figure out exactly which one was causing the complaint I
> just defaulted to TCG_COND_ALWAYS and allowed that state to double up
> for the now defunct bcond_compute variable.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/mips/translate.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
This looks like a good cleanup.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-09-03 17:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 11:20 [PATCH v1 0/8] some testing and CI updates (re-greening) Alex Bennée
2020-09-03 11:21 ` [PATCH v1 1/8] CODING_STYLE.rst: flesh out our naming conventions Alex Bennée
2020-09-03 12:24 ` Paolo Bonzini
2020-09-03 11:21 ` [PATCH v1 2/8] crypto: fix build with gcrypt enabled Alex Bennée
2020-09-03 19:02 ` Richard Henderson
2020-09-03 11:21 ` [PATCH v1 3/8] tests/docker: add python3-setuptools the docker images Alex Bennée
2020-09-03 11:40 ` Thomas Huth
2020-09-03 19:30 ` Philippe Mathieu-Daudé
2020-09-03 11:21 ` [PATCH v1 4/8] usb-host: restrict workaround to new libusb versions Alex Bennée
2020-09-03 11:21 ` [PATCH v1 5/8] qemu-iotests: move check-block back to Makefiles Alex Bennée
2020-09-03 11:21 ` [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG Alex Bennée
2020-09-03 12:10 ` Paolo Bonzini
2020-09-07 9:11 ` Alex Bennée
2020-09-07 9:41 ` Philippe Mathieu-Daudé
2020-09-07 9:55 ` Alex Bennée
2020-09-07 10:08 ` Philippe Mathieu-Daudé
2020-09-03 11:21 ` [PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic Alex Bennée
2020-09-03 17:16 ` Richard Henderson [this message]
2020-09-03 11:21 ` [PATCH v1 8/8] migration: use pstrcpy to copy run state Alex Bennée
2020-09-03 12:13 ` Paolo Bonzini
2020-09-03 19:43 ` Philippe Mathieu-Daudé
2020-09-04 10:03 ` Alex Bennée
2020-09-03 11:34 ` [PATCH v1 0/8] some testing and CI updates (re-greening) Daniel P. Berrangé
2020-09-03 14:17 ` Thomas Huth
2020-09-03 14:38 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64aaeb37-04fd-d57d-3c1b-3a8d70ec9f2a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).