From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Nikola Pavlica" <pavlica.nikola@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later
Date: Thu, 16 Jan 2020 11:20:41 +0100 [thread overview]
Message-ID: <64afd282-6dde-43b3-d8de-a645b5f97802@redhat.com> (raw)
In-Reply-To: <20200116101606.GA533908@redhat.com>
On 1/16/20 11:16 AM, Daniel P. Berrangé wrote:
> On Thu, Jan 16, 2020 at 02:12:17AM +0100, Philippe Mathieu-Daudé wrote:
>> The GdkMonitor was introduced in GTK+ 3.22:
>> https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22
>>
>> If we build with older GTK+, the build fails:
>
> Presumably the problem here is Ubuntu Xenial 16.04 which
> only has 3.18.9 ?
Indeed:
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.5 LTS
Release: 16.04
Codename: xenial
$ pkg-config --modversion gtk+-3.0
3.18.9
> We should put in a sanity check for this against our min version
>
> #define GDK_VERSION_MIN_REQUIRED GDK_VERSION_3_14
> #define GDK_VERSION_MAX_ALLOWED GDK_VERSION_3_14
>
> into glib-compat.h
>
> For that matter we can update our min version to 3.18 I believe
> since that looks like the oldest version any supported build
> platform has.
>
> Regards,
> Daniel
>
next prev parent reply other threads:[~2020-01-16 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 1:12 [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later Philippe Mathieu-Daudé
2020-01-16 8:13 ` Gerd Hoffmann
2020-01-16 10:16 ` Daniel P. Berrangé
2020-01-16 10:20 ` Philippe Mathieu-Daudé [this message]
2020-02-08 10:54 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64afd282-6dde-43b3-d8de-a645b5f97802@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pavlica.nikola@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).