qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@loongson.cn>,
	Song Gao <gaosong@loongson.cn>,
	Xiaojuan Yang <yangxiaojuan@loongson.cn>, Jiajie Chen <c@jia.je>
Subject: Re: [PATCH 3/4] target/loongarch: Rename 64-bit specific functions
Date: Fri, 18 Aug 2023 08:59:21 -0700	[thread overview]
Message-ID: <64b018a9-917b-0f83-9d8c-1491f0d676dd@linaro.org> (raw)
In-Reply-To: <20230818103425.16271-4-philmd@linaro.org>

On 8/18/23 03:34, Philippe Mathieu-Daudé wrote:
> These functions are specific to loongarch64 cores. Rename
> including the '64' suffix in preparation of supporting
> loongarch32 cores.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/loongarch/cpu.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
> index dc617be36f..19572e37ad 100644
> --- a/target/loongarch/cpu.c
> +++ b/target/loongarch/cpu.c
> @@ -76,7 +76,7 @@ void G_NORETURN do_raise_exception(CPULoongArchState *env,
>       cpu_loop_exit_restore(cs, pc);
>   }
>   
> -static void loongarch_cpu_set_pc(CPUState *cs, vaddr value)
> +static void loongarch64_cpu_set_pc(CPUState *cs, vaddr value)
>   {
>       LoongArchCPU *cpu = LOONGARCH_CPU(cs);
>       CPULoongArchState *env = &cpu->env;
> @@ -84,7 +84,7 @@ static void loongarch_cpu_set_pc(CPUState *cs, vaddr value)
>       env->pc = value;
>   }
>   
> -static vaddr loongarch_cpu_get_pc(CPUState *cs)
> +static vaddr loongarch64_cpu_get_pc(CPUState *cs)
>   {
>       LoongArchCPU *cpu = LOONGARCH_CPU(cs);
>       CPULoongArchState *env = &cpu->env;
> @@ -356,7 +356,7 @@ static bool loongarch_cpu_has_work(CPUState *cs)
>   #endif
>   }

Not 64-bit specific.


r~


  reply	other threads:[~2023-08-18 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 10:34 [PATCH 0/4] target/loongarch: Cleanups in preparation of loongarch32 support Philippe Mathieu-Daudé
2023-08-18 10:34 ` [PATCH 1/4] target/loongarch: Log I/O write accesses to CSR registers Philippe Mathieu-Daudé
2023-08-18 10:34 ` [PATCH 2/4] target/loongarch: Remove duplicated disas_set_info assignment Philippe Mathieu-Daudé
2023-08-18 15:58   ` Richard Henderson
2023-08-18 10:34 ` [PATCH 3/4] target/loongarch: Rename 64-bit specific functions Philippe Mathieu-Daudé
2023-08-18 15:59   ` Richard Henderson [this message]
2023-08-18 10:34 ` [PATCH 4/4] target/loongarch: Extract 64-bit specifics to loongarch64_cpu_class_init Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64b018a9-917b-0f83-9d8c-1491f0d676dd@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=c@jia.je \
    --cc=chenhuacai@loongson.cn \
    --cc=gaosong@loongson.cn \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yangxiaojuan@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).