From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Cornelia Huck <cohuck@redhat.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
David Hildenbrand <david@redhat.com>,
Anthony Green <green@moxielogic.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Max Filippov <jcmvbkbc@gmail.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>, Marek Vasut <marex@denx.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
David Gibson <david@gibson.dropbear.id.au>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
Stafford Horne <shorne@gmail.com>,
Richard Henderson <rth@twiddle.net>,
qemu-riscv@nongnu.org,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Chris Wulff <crwulff@gmail.com>,
Claudio Fontana <claudio.fontana@huawei.com>,
Laurent Vivier <laurent@vivier.eu>,
Michael Walle <michael@walle.cc>,
qemu-ppc@nongnu.org, Aleksandar Markovic <amarkovic@wavecomp.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/2] tcg: Search includes from the project root source directory
Date: Mon, 30 Dec 2019 10:59:40 +0100 [thread overview]
Message-ID: <64c2434d-3b2b-1a3e-5358-e4b5acfbe8e8@redhat.com> (raw)
In-Reply-To: <273bf2e5-1223-3d01-f930-394195c037e4@weilnetz.de>
Hi Stefan,
On 12/30/19 10:53 AM, Stefan Weil wrote:
> Am 30.12.19 um 10:08 schrieb Philippe Mathieu-Daudé:
>
> [...]
>
>> tcg/tcg-op.h | 2 +-
>> tcg/tcg.h | 4 ++--
>> tcg/tcg-common.c | 2 +-
>> tcg/tcg-op-gvec.c | 8 ++++----
>> tcg/tcg-op-vec.c | 6 +++---
>> tcg/tcg-op.c | 6 +++---
>> tcg/tcg.c | 2 +-
>> tcg/tci.c | 2 +-
>
>
> Source files in the tcg directory should not need any change because
> they find include files in the same directory without searching.
>
> If we add a tcg/ include file prefix for them as well, that has the
> advantage that it might look prettier and more uniform, but it has the
> disadvantage of requiring a search by the preprocessor.
Yeah, I was not sure about these specific files. My first attempt was
without modifying them, but then I thought it would be better to keep
the codebase uniform, as you said.
>
> I'd prefer not changing those files.
OK, I'll wait to see what Richard/Markus prefer.
> Regards and best wished for 2020
Thanks ;)
next prev parent reply other threads:[~2019-12-30 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 9:08 [PATCH 0/2] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list Philippe Mathieu-Daudé
2019-12-30 9:08 ` [PATCH 1/2] tcg: Search includes from the project root source directory Philippe Mathieu-Daudé
2019-12-30 9:53 ` Stefan Weil
2019-12-30 9:59 ` Philippe Mathieu-Daudé [this message]
2019-12-30 10:33 ` Paolo Bonzini
2019-12-30 14:02 ` Philippe Mathieu-Daudé
2019-12-30 15:48 ` Philippe Mathieu-Daudé
2019-12-30 17:46 ` Paolo Bonzini
2019-12-30 9:09 ` [PATCH 2/2] configure: Remove tcg/ from the preprocessor include search list Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c2434d-3b2b-1a3e-5358-e4b5acfbe8e8@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=claudio.fontana@huawei.com \
--cc=cohuck@redhat.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=shorne@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).