From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 01/10] target/i386: use cpu_cc_dst for CC_OP_POPCNT
Date: Thu, 20 Jun 2024 08:02:59 -0700 [thread overview]
Message-ID: <64d018d2-ab53-47b3-963e-ad9abf41896c@linaro.org> (raw)
In-Reply-To: <20240620095419.386958-2-pbonzini@redhat.com>
On 6/20/24 02:54, Paolo Bonzini wrote:
> It is the only POPCNT that computes ZF from one of the cc_op_* registers,
> but it uses cpu_cc_src instead of cpu_cc_dst like the others. Do not
> make it the odd one off.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> target/i386/cpu.h | 2 +-
> target/i386/tcg/cc_helper.c | 2 +-
> target/i386/tcg/translate.c | 2 +-
> target/i386/tcg/emit.c.inc | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-06-20 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 9:54 [PATCH 00/10] target/i386: make decoding entirely table based Paolo Bonzini
2024-06-20 9:54 ` [PATCH 01/10] target/i386: use cpu_cc_dst for CC_OP_POPCNT Paolo Bonzini
2024-06-20 15:02 ` Richard Henderson [this message]
2024-06-20 9:54 ` [PATCH 02/10] target/i386: give CC_OP_POPCNT low bits corresponding to MO_TL Paolo Bonzini
2024-06-20 15:10 ` Richard Henderson
2024-06-20 9:54 ` [PATCH 03/10] target/i386: convert bit test instructions to new decoder Paolo Bonzini
2024-06-20 15:22 ` Richard Henderson
2024-06-20 9:54 ` [PATCH 04/10] target/i386: try not to force EFLAGS computation for CC_OP_ADOX/ADCX Paolo Bonzini
2024-06-20 15:56 ` Richard Henderson
2024-06-20 9:54 ` [PATCH 05/10] target/i386: decode address before going back to translate.c Paolo Bonzini
2024-06-20 9:54 ` [PATCH 06/10] target/i386: convert CMPXCHG8B/CMPXCHG16B to new decoder Paolo Bonzini
2024-06-20 16:14 ` Richard Henderson
2024-06-20 9:54 ` [PATCH 07/10] target/i386: do not check PREFIX_LOCK in old-style decoder Paolo Bonzini
2024-06-20 9:54 ` [PATCH 08/10] target/i386: list instructions still in translate.c Paolo Bonzini
2024-06-20 9:54 ` [PATCH 09/10] target/i386: assert that cc_op* and pc_save are preserved Paolo Bonzini
2024-06-20 9:54 ` [PATCH 10/10] target/i386: remove gen_ext_tl Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d018d2-ab53-47b3-963e-ad9abf41896c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).