From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cscPv-0000ia-Qy for qemu-devel@nongnu.org; Mon, 27 Mar 2017 17:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cscPt-0002bP-7g for qemu-devel@nongnu.org; Mon, 27 Mar 2017 17:43:11 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:35468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cscPt-0002bD-0V for qemu-devel@nongnu.org; Mon, 27 Mar 2017 17:43:09 -0400 Received: by mail-pg0-x241.google.com with SMTP id g2so16026842pge.2 for ; Mon, 27 Mar 2017 14:43:08 -0700 (PDT) Sender: Richard Henderson References: From: Richard Henderson Message-ID: <64d527bd-c639-7300-0a23-a70e739f8fe8@twiddle.net> Date: Tue, 28 Mar 2017 07:43:01 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] packed structures and unaligned accesses (sparc) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers Cc: Knut Omang , John Paul Adrian Glaubitz On 03/28/2017 03:34 AM, Peter Maydell wrote: > That all makes sense in isolation, but shouldn't something have > at least warned that "&h.size" isn't actually a uint32_t* in > the sense of being something you can validly pass to a > function that takes a uint32_t* ? That's a long-known bug in the implementation of packed data. Yes, it should, but it doesn't. r~