From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1yYo-0003qA-8M for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:38:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1yYj-0002Bh-CZ for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:38:46 -0400 References: <1477943636-21024-1-git-send-email-duanj@linux.vnet.ibm.com> <1477943636-21024-3-git-send-email-duanj@linux.vnet.ibm.com> <87k2cm88j0.fsf@emacs.mitica> From: Paolo Bonzini Message-ID: <64de4199-2588-fc76-a09d-132045a29ed0@redhat.com> Date: Wed, 2 Nov 2016 17:38:29 +0100 MIME-Version: 1.0 In-Reply-To: <87k2cm88j0.fsf@emacs.mitica> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, Jianjun Duan Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, dmitry@daynix.com, peter.maydell@linaro.org, kraxel@redhat.com, mst@redhat.com, david@gibson.dropbear.id.au, veroniabahaa@gmail.com, amit.shah@redhat.com, mreitz@redhat.com, kwolf@redhat.com, rth@twiddle.net, aurelien@aurel32.net, leon.alrae@imgtec.com, blauwirbel@gmail.com, mark.cave-ayland@ilande.co.uk, mdroth@linux.vnet.ibm.com, dgilbert@redhat.com On 02/11/2016 11:45, Juan Quintela wrote: >> > + while (qemu_get_byte(f)) { >> > + elm = g_malloc(size); > I think this is not generic enough. We really need to allocate a new > element, and then fill it with default values. > > virtio list code use it in this way. One thing at a time? The allocation and "looping" are different mechanisms. We can customize the allocation later. Paolo