From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch
Date: Thu, 9 Jul 2020 12:59:58 +0200 [thread overview]
Message-ID: <64e5ec54-a2f8-d6bb-4b1c-de7cf1eed372@redhat.com> (raw)
In-Reply-To: <20200709105121.GB511889@stefanha-x1.localdomain>
On 09/07/2020 12.51, Stefan Hajnoczi wrote:
> On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote:
>> diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c
>> index f0b66320e1..a4e6446ed9 100644
>> --- a/util/coroutine-ucontext.c
>> +++ b/util/coroutine-ucontext.c
>> @@ -237,19 +237,15 @@ Coroutine *qemu_coroutine_new(void)
>> }
>>
>> #ifdef CONFIG_VALGRIND_H
>> -#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && !defined(__clang__)
>> /* Work around an unused variable in the valgrind.h macro... */
>> #pragma GCC diagnostic push
>> #pragma GCC diagnostic ignored "-Wunused-but-set-variable"
>> -#endif
>
> What about !defined(__clang__)? Looks like this will break clang builds:
>
> warning: unknown warning option '-Wunused-but-set-variable'; did you mean '-Wunused-const-variable'? [-Wunknown-warning-option]
Oh, I didn't hit this problem in the CI:
https://gitlab.com/huth/qemu/-/jobs/629814877#L2287
... which version of Clang are you using? Anyway, I'll put the
!defined(__clang__) back here, thanks for reporting it!
Thomas
prev parent reply other threads:[~2020-07-09 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 5:34 [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch Thomas Huth
2020-07-09 8:39 ` Daniel P. Berrangé
2020-07-09 9:58 ` Paolo Bonzini
2020-07-09 10:51 ` Stefan Hajnoczi
2020-07-09 10:59 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e5ec54-a2f8-d6bb-4b1c-de7cf1eed372@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).