From: Eric Blake <eblake@redhat.com>
To: Li Qiang <liq3ea@gmail.com>, armbru@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo
Date: Mon, 5 Nov 2018 17:01:50 -0600 [thread overview]
Message-ID: <64f88d81-8de1-a4b3-196f-c5c95a45e4e5@redhat.com> (raw)
In-Reply-To: <1541156463-2730-1-git-send-email-liq3ea@gmail.com>
On 11/2/18 6:01 AM, Li Qiang wrote:
> When trigger a 'query-cpus' qmp, the pc is an signed value like
> following:
> {"arch": "x86", ... "pc": -1732653994, "halted": true,...}
> It is strange. Change it to uint64_t.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> qapi/misc.json | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
I don't see this as causing any major backwards-incompatible behavior to
clients that can parse full 64-bit unsigned numbers (note that not all
JSON parsers do so - here's frowning at you, jansson - but libvirt is okay).
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-11-05 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 11:01 [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo Li Qiang
2018-11-05 23:01 ` Eric Blake [this message]
2018-11-29 15:38 ` [Qemu-devel] QAPI 'size' vs. 'uint64' (was: [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo) Markus Armbruster
2018-11-06 9:11 ` [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f88d81-8de1-a4b3-196f-c5c95a45e4e5@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=liq3ea@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).