From: Eric Blake <eblake@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
David Gibson <david@gibson.dropbear.id.au>
Cc: paulus@ozlabs.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS
Date: Thu, 18 Jan 2018 14:30:27 -0600 [thread overview]
Message-ID: <650522f0-9667-f6c5-1c45-b54619440b69@redhat.com> (raw)
In-Reply-To: <3680b2ae-def7-9b00-81d8-eb66ec0bea4e@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On 01/18/2018 02:11 AM, Alexey Kardashevskiy wrote:
>>>> I think you just assert() for this. The only way these could get a
>>>> different value is if there's a bug elsewhere.
>>>
>>>
>>> Why not return H_HARDWARE or other error?
>>
>> Because what's the guest supposed to do with it.
>
> "oops"
>
>> This is an internal
>> qemu problem, so it should be dealt with via an internal qemu
>> mechanism.
>
> Do we have assert() enabled in production? If not, then assert == noop,
> error_report is just a noise.
See commit 262a69f4. Yes, assert() is enabled in production, for
security reasons (aka it's easier to do that than to audit that
migration is still safe even with no-op asserts).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-01-18 20:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 6:32 [Qemu-devel] [QEMU-PPC] [PATCH V3 0/6] target/ppc: Rework spapr_caps Suraj Jitindar Singh
2018-01-15 6:32 ` [Qemu-devel] [QEMU-PPC] [PATCH V3 1/6] target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch] Suraj Jitindar Singh
2018-01-15 6:58 ` [Qemu-devel] [QEMU-PPC] [PATCH V4 " Suraj Jitindar Singh
2018-01-18 5:06 ` David Gibson
2018-01-15 6:32 ` [Qemu-devel] [QEMU-PPC] [PATCH V3 2/6] target/ppc/spapr_caps: Add support for tristate spapr_capabilities Suraj Jitindar Singh
2018-01-18 5:07 ` David Gibson
2018-01-15 6:32 ` [Qemu-devel] [QEMU-PPC] [PATCH V3 3/6] target/ppc/spapr_caps: Add new tristate cap safe_cache Suraj Jitindar Singh
2018-01-18 5:10 ` David Gibson
2018-01-15 6:32 ` [Qemu-devel] [QEMU-PPC] [PATCH V3 4/6] target/ppc/spapr_caps: Add new tristate cap safe_bounds_check Suraj Jitindar Singh
2018-01-18 5:11 ` David Gibson
2018-01-15 6:32 ` [Qemu-devel] [QEMU-PPC] [PATCH V3 5/6] target/ppc/spapr_caps: Add new tristate cap safe_indirect_branch Suraj Jitindar Singh
2018-01-18 5:11 ` David Gibson
2018-01-15 6:32 ` [Qemu-devel] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS Suraj Jitindar Singh
2018-01-18 5:20 ` David Gibson
2018-01-18 5:44 ` [Qemu-devel] [Qemu-ppc] " Alexey Kardashevskiy
2018-01-18 5:53 ` David Gibson
2018-01-18 8:11 ` Alexey Kardashevskiy
2018-01-18 20:30 ` Eric Blake [this message]
2018-01-18 23:35 ` David Gibson
2018-01-18 23:33 ` David Gibson
2018-01-16 13:47 ` [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 0/6] target/ppc: Rework spapr_caps Andrea Bolognani
2018-01-16 13:54 ` David Gibson
2018-01-16 14:46 ` Andrea Bolognani
2018-01-16 22:34 ` David Gibson
2018-01-16 23:26 ` Alexey Kardashevskiy
2018-01-16 23:30 ` David Gibson
2018-01-16 23:46 ` Alexey Kardashevskiy
2018-01-17 1:15 ` David Gibson
2018-01-17 8:54 ` Andrea Bolognani
2018-01-18 4:27 ` David Gibson
2018-01-18 15:55 ` Andrea Bolognani
2018-01-19 2:22 ` David Gibson
2018-01-19 3:59 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=650522f0-9667-f6c5-1c45-b54619440b69@redhat.com \
--to=eblake@redhat.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=paulus@ozlabs.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sjitindarsingh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).