From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRz0a-0005zH-AO for qemu-devel@nongnu.org; Mon, 03 Jul 2017 06:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRz0X-0003R7-5X for qemu-devel@nongnu.org; Mon, 03 Jul 2017 06:55:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44954) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dRz0W-0003Pc-VX for qemu-devel@nongnu.org; Mon, 03 Jul 2017 06:55:09 -0400 References: <1499076743-15477-1-git-send-email-yang.zhong@intel.com> <1499076743-15477-2-git-send-email-yang.zhong@intel.com> <20170703102043.GE5663@redhat.com> <68cbc479-3707-cdab-4dcd-d055b02ede7d@redhat.com> <20170703103340.GF5663@redhat.com> From: Paolo Bonzini Message-ID: <650bf1e9-ba8c-c7a5-9e48-94dc970523d6@redhat.com> Date: Mon, 3 Jul 2017 12:55:04 +0200 MIME-Version: 1.0 In-Reply-To: <20170703103340.GF5663@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Yang Zhong , rth@twiddle.net, thuth@redhat.com, anthony.xu@intel.com, qemu-devel@nongnu.org, a.rigo@virtualopensystems.com On 03/07/2017 12:33, Daniel P. Berrange wrote: >> i386-softmmu and x86_64-softmmu are singled out here, because they're >> the only targets where --disable-tcg compiles. For the others, more >> work is needed (see patches 6-15 in Yang Zhong's series). > > Even with that, you still can't disable TCG if building on a non-x86 > host, since that'd leave you with no available CPU at all. So the > code still needs refactoring to check architectures properly. It would leave you with a tools-only build; whether that's a good idea, it's another story. I think it's acceptable, but others may disagree. Paolo >> The part that is missing in this patch is disabling non-hypervisor >> targets when --disable-tcg is specified. My original patch built only >> i386-softmmu and x86_64-softmmu if you specified --disable-tcg, see >> >> https://lists.nongnu.org/archive/html/qemu-devel/2012-09/msg02570.html >> https://lists.nongnu.org/archive/html/qemu-devel/2012-09/msg02571.html