From: David Hildenbrand <david@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 10/10] spapr_pci: perform unplug via the hotplug handler
Date: Mon, 5 Nov 2018 11:33:04 +0100 [thread overview]
Message-ID: <650cbff1-f3b8-1bb9-1e79-30a8a5f1c94e@redhat.com> (raw)
In-Reply-To: <20181105113159.78c714e1@bahia.lan>
On 05.11.18 11:31, Greg Kurz wrote:
> On Mon, 5 Nov 2018 11:20:44 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> Introduce and use the "unplug" callback.
>>
>> This is a preparation for multi-stage hotplug handlers, whereby the bus
>> hotplug handler is overwritten by the machine hotplug handler. This handler
>> will then pass control to the bus hotplug handler. So to get this running
>> cleanly, we also have to make sure to go via the hotplug handler chain when
>> actually unplugging a device after an unplug request. Lookup the hotplug
>> handler and call "unplug".
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
BTW, sorry for dropping you RB! (realized it just now)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-11-05 10:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 10:20 [Qemu-devel] [PATCH v2 00/10] pci: hotplug handler reworks David Hildenbrand
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 01/10] pci/pcie: rename hotplug handler callbacks David Hildenbrand
2018-11-06 6:03 ` David Gibson
2018-11-06 8:43 ` David Hildenbrand
2018-11-19 15:43 ` Igor Mammedov
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 02/10] pci/shpc: " David Hildenbrand
2018-11-06 8:14 ` David Gibson
2018-11-19 15:56 ` Igor Mammedov
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 03/10] s390x/pci: " David Hildenbrand
2018-11-06 8:14 ` David Gibson
2018-11-08 12:38 ` Cornelia Huck
2018-11-19 15:59 ` Igor Mammedov
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 04/10] pci/pcie: stop plug/unplug if the slot is locked David Hildenbrand
2018-11-06 23:10 ` David Gibson
2018-11-07 9:03 ` David Hildenbrand
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 05/10] pci/pcihp: perform check for bus capability in pre_plug handler David Hildenbrand
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 06/10] pci/pcihp: overwrite hotplug handler recursively from the start David Hildenbrand
2018-11-19 16:31 ` Igor Mammedov
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 07/10] pci/pcihp: perform unplug via the hotplug handler David Hildenbrand
2018-11-19 16:36 ` Igor Mammedov
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 08/10] pci/pcie: " David Hildenbrand
2018-11-07 0:55 ` David Gibson
2018-11-19 16:46 ` Igor Mammedov
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 09/10] pci/shpc: " David Hildenbrand
2018-11-07 0:59 ` David Gibson
2018-11-19 17:09 ` Igor Mammedov
2018-11-20 10:11 ` David Hildenbrand
2018-11-20 14:13 ` Igor Mammedov
2018-11-20 14:34 ` David Hildenbrand
2018-11-05 10:20 ` [Qemu-devel] [PATCH v2 10/10] spapr_pci: " David Hildenbrand
2018-11-05 10:31 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-11-05 10:33 ` David Hildenbrand [this message]
2018-11-07 4:22 ` [Qemu-devel] " David Gibson
2018-11-08 3:08 ` [Qemu-devel] QEMU bootup hang in tcg model using mainline QEMU code gengdongjiu
2018-11-19 17:13 ` [Qemu-devel] [PATCH v2 10/10] spapr_pci: perform unplug via the hotplug handler Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=650cbff1-f3b8-1bb9-1e79-30a8a5f1c94e@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).