From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJcCY-0001CO-Ff for qemu-devel@nongnu.org; Mon, 05 Nov 2018 05:33:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJcCV-0000MR-Qn for qemu-devel@nongnu.org; Mon, 05 Nov 2018 05:33:46 -0500 References: <20181105102044.20547-1-david@redhat.com> <20181105102044.20547-11-david@redhat.com> <20181105113159.78c714e1@bahia.lan> From: David Hildenbrand Message-ID: <650cbff1-f3b8-1bb9-1e79-30a8a5f1c94e@redhat.com> Date: Mon, 5 Nov 2018 11:33:04 +0100 MIME-Version: 1.0 In-Reply-To: <20181105113159.78c714e1@bahia.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 10/10] spapr_pci: perform unplug via the hotplug handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, Eduardo Habkost , "Michael S . Tsirkin" , Cornelia Huck , "Dr . David Alan Gilbert" , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , Igor Mammedov , Richard Henderson , David Gibson On 05.11.18 11:31, Greg Kurz wrote: > On Mon, 5 Nov 2018 11:20:44 +0100 > David Hildenbrand wrote: > >> Introduce and use the "unplug" callback. >> >> This is a preparation for multi-stage hotplug handlers, whereby the bus >> hotplug handler is overwritten by the machine hotplug handler. This handler >> will then pass control to the bus hotplug handler. So to get this running >> cleanly, we also have to make sure to go via the hotplug handler chain when >> actually unplugging a device after an unplug request. Lookup the hotplug >> handler and call "unplug". >> >> Signed-off-by: David Hildenbrand >> --- > > Reviewed-by: Greg Kurz BTW, sorry for dropping you RB! (realized it just now) -- Thanks, David / dhildenb