From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJghp-0004NZ-0y for qemu-devel@nongnu.org; Tue, 28 Nov 2017 09:17:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJghn-0005s9-0g for qemu-devel@nongnu.org; Tue, 28 Nov 2017 09:17:48 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJghm-0005s3-P2 for qemu-devel@nongnu.org; Tue, 28 Nov 2017 09:17:46 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vASEHTal082496 for ; Tue, 28 Nov 2017 09:17:43 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2eh8fg3mkq-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 28 Nov 2017 09:17:42 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 28 Nov 2017 14:17:40 -0000 References: <20171128134648.21530-1-cohuck@redhat.com> From: Halil Pasic Date: Tue, 28 Nov 2017 15:17:38 +0100 MIME-Version: 1.0 In-Reply-To: <20171128134648.21530-1-cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: <6513d1c5-032e-b9d0-3dab-f2d0bd337ae2@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: borntraeger@de.ibm.com, pmorel@linux.vnet.ibm.com On 11/28/2017 02:46 PM, Cornelia Huck wrote: > info qom-tree shows several devices under unattached that probably > should go somewhere. I think this was reported by me. See MID: <76f95c6f-641e-2fe0-73b4-3ab24fc1a93f@linux.vnet.ibm.com> I would not mind a Reported-by: Halil Pasic . Or do you see this differently? If these are bugs. I would prefer commit messages and titles reflecting this fact. Otherwise at first glance both patches seem sane. Regards, Halil > > The css bridge should attach to the machine, as it has a similar > purpose as e.g. a pci host bridge. > > The autogenerated network devices should be in the same bucket as any > other device; I'm just not sure about the way I went about it. > > The zpci devices are still problematic: I don't have a good idea where > they should show up. > > Remaining in the unattached container are the sysbus, memory regions > and cpus. > > Cornelia Huck (2): > s390x/css: attach css bridge > s390x: attach autogenerated nics > > hw/s390x/css-bridge.c | 2 ++ > hw/s390x/s390-virtio-ccw.c | 2 ++ > 2 files changed, 4 insertions(+) >