From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blbag-0001o8-Ib for qemu-devel@nongnu.org; Sun, 18 Sep 2016 08:53:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blbac-0003uR-Co for qemu-devel@nongnu.org; Sun, 18 Sep 2016 08:53:01 -0400 Received: from mout.web.de ([212.227.17.11]:59654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blbac-0003uB-3c for qemu-devel@nongnu.org; Sun, 18 Sep 2016 08:52:58 -0400 References: <566ABCD9.1060404@users.sourceforge.net> From: SF Markus Elfring Message-ID: <6517cf5c-06ea-8b97-b2f2-b4e0253ed48f@users.sourceforge.net> Date: Sun, 18 Sep 2016 14:52:47 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 2/6] firmware-qemu_fw_cfg: Improve a size determination in fw_cfg_register_file() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Gabriel Somlo , "Michael S. Tsirkin" Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 18 Sep 2016 10:43:27 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/firmware/qemu_fw_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index e69653e..a229df6 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -458,7 +458,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) return -ENOMEM; /* set file entry information */ - memcpy(&entry->f, f, sizeof(struct fw_cfg_file)); + memcpy(&entry->f, f, sizeof(*f)); /* register entry under "/sys/firmware/qemu_fw_cfg/by_key/" */ err = kobject_init_and_add(&entry->kobj, &fw_cfg_sysfs_entry_ktype, -- 2.10.0