From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0169BC433EF for ; Fri, 3 Sep 2021 21:13:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF80F61101 for ; Fri, 3 Sep 2021 21:13:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF80F61101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMGVD-0001nx-05 for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 17:13:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMGTw-0007Wj-V4 for qemu-devel@nongnu.org; Fri, 03 Sep 2021 17:12:17 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:36593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMGTt-0001aS-At for qemu-devel@nongnu.org; Fri, 03 Sep 2021 17:12:15 -0400 Received: by mail-wr1-x42a.google.com with SMTP id q14so487192wrp.3 for ; Fri, 03 Sep 2021 14:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GdDA6MxFGVSUTkeK52CHpe7SqeTujh6NGjzSvPioDWk=; b=bpXmTL2aGyBDKXUcCq1DSvlAPrTeR8qlIvM4nBdbQwLlZKPL0OmChmXRrwwqgQx+lv LJhZvFDLHfmCtd0eGNWDpRoQLiYrUYTfJN05e57110gwXb4ZcLrZ1XfARby+6I7kX4zL PEkID0d/byeDH01x8IwIte4CnZD8gDCWf9HRNI7g5gvmsGwUugnxt78W87tJAs//kqmV nEhWVg0+kDYvBdVcdGwf21xgVJxregYk56IYiMpr6qcJt1XfZwFbKiYa78STXQwlx95o jSb1RxfcF6xasArA4EqziaA76dhklsj4dVJJ1k6BBGypgyKj1ulDINm9m51MUcXl6Ozc 9f8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GdDA6MxFGVSUTkeK52CHpe7SqeTujh6NGjzSvPioDWk=; b=adkYQdUMlKbELuiTMxaKgv/hUVN/0ptjgvcU37LBZEYZeihDMA0O+QjjgDR2FXG2jB JfNYDjWoN1ni3AfxadkuMmaIXMQjx/KQ1nidksX0+4cj+6GuQa/hBz9u4R60eMvHsJoS vMsFKxI4hQhF750Pi0WvwrYlmWweemX+O0UA1lX7PRwz8B6PMzY1uy8S262MBRzYVVDO XJ2xF3UYxuDlZ+heMnSHa8SkfcrlB9jdSHfOK2Syl3d5nqSoxo4JEkAZtbW3alJgiGjK fHutDh5xBOFpiMJkUknZGOv/yQDPYHIkc82C4bWsSy6Ly+mIMPmIZfhfgsUfWIS5kXSD n28g== X-Gm-Message-State: AOAM531uVyUC9OZMVaZyOn6Kj+JNbZJnuXMtgpFpYCHSEN3WK244qAR3 Bk3gWf3dU8ImT526EGZPHhMT6g== X-Google-Smtp-Source: ABdhPJyTfujJIlCT9r9rbl9FWjTC1s8Jfo/joQRAre0dWajLhDaK/compIWW7EkCzgqCb76mRMqESQ== X-Received: by 2002:adf:e0cc:: with SMTP id m12mr1010295wri.62.1630703531920; Fri, 03 Sep 2021 14:12:11 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id r15sm499117wmh.27.2021.09.03.14.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 14:12:11 -0700 (PDT) Subject: Re: [PATCH v2 10/19] host-utils: Introduce mulu128 To: Luis Pires , qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20210831164007.297781-1-luis.pires@eldorado.org.br> <20210831164007.297781-11-luis.pires@eldorado.org.br> From: Richard Henderson Message-ID: <651bcc3e-1381-e886-f6dc-3e7673b50eeb@linaro.org> Date: Fri, 3 Sep 2021 23:12:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210831164007.297781-11-luis.pires@eldorado.org.br> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.888, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: groug@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/31/21 6:39 PM, Luis Pires wrote: > + *phigh = ahi + blo; > + > + return (bhi > 0) || (*phigh < ahi); return add64_overflow(ahi, blo, phigh) || bhi != 0 With that, Reviewed-by: Richard Henderson r~