From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4957C678D4 for ; Mon, 6 Mar 2023 15:23:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZCfy-0005bH-9y; Mon, 06 Mar 2023 10:22:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCfx-0005Xy-4n for qemu-devel@nongnu.org; Mon, 06 Mar 2023 10:22:57 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZCfu-0007y9-BH for qemu-devel@nongnu.org; Mon, 06 Mar 2023 10:22:56 -0500 Received: by mail-wm1-x335.google.com with SMTP id c18so5902416wmr.3 for ; Mon, 06 Mar 2023 07:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678116172; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zaZzsHFDAUulgPgGq9RguUXw3QMu9+56YCieruNcXXI=; b=c7QSTelMP52C0T+LH3uI4z+izyvCVWq3rMkgcJZM0Oxv7yItWV0PtyaMoAfCkzc0iK IMgVp16UUpFJSmq2wUmrpxqwMDkNV4LZ3b9sU+Jo+MBxqwMJ0dOqDJhwkh8xiU/+NDde UJw3O0yoRFKuRzwvMnIBlVf4pu7mUboLiqE5hLOgrzG6dncfaoZKxyqZw9TW92HolWMw LriMP6tHWmlwbLvQIqV0vB3NH42jtF6cQPRKj8Z+A/c5TKy9sbvq5LH9AeN3bC9Q9uOt HvQY9MOUTxjKRlVuCo3vWXLWL8NKjYnj2CCa0eDORQYKHhw4/LZWNrX7IBgABROsggSz XAKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678116172; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zaZzsHFDAUulgPgGq9RguUXw3QMu9+56YCieruNcXXI=; b=d24pss1+Ww0FmZySBMRQDcLUtJmeEQekydPm9Lv1O9kasvE22Ihw+qID9dcE1eH5Ty Jb03LCO+QIGxF9oY0qgdB8eWME3nqKGWhXLnZbmuP0mUgmjXgA45eklA/68O+EkoF1Ka h3YhsfNHS/sTsnd9opWy3J74UDOXTN74v+w95j0MaEiMTY57AK2K79JZkm9gyO6DLork Yy90w92iCEYkNYO1fm7VP0Kfqw5VqiSM8R4PG7ew2Ky4dDALgadQs0SInwBcWpEsULzK avHF7nfFVmI0jYmR/ZUGgcEiP8LWU7aTtD3nUYcPmzTYx/EZGSD0WP04fuayaaWnlO42 KW/g== X-Gm-Message-State: AO0yUKUrcCHQOkja/AlGP4jexsxpcInb7LcXDg5UTpSDw5RcMztTHviF /jra8owhbzlRPFO6MehnCN7Q1w== X-Google-Smtp-Source: AK7set/RaZMfpZ5TGLTlgaXyai2lkOwpe1o6Mf9xtFEWlE/XRwh1aNal0PhVUA52Yk3RoeFLwphvxA== X-Received: by 2002:a05:600c:6001:b0:3eb:38e6:f650 with SMTP id az1-20020a05600c600100b003eb38e6f650mr9546881wmb.41.1678116172461; Mon, 06 Mar 2023 07:22:52 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id n37-20020a05600c3ba500b003e2052bad94sm15658781wms.33.2023.03.06.07.22.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 07:22:51 -0800 (PST) Message-ID: <651db4ce-9085-2f48-f1e7-295884759833@linaro.org> Date: Mon, 6 Mar 2023 16:22:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 11/70] target/arm: Avoid tcg_const_ptr in handle_rev Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230227054233.390271-1-richard.henderson@linaro.org> <20230227054233.390271-12-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230227054233.390271-12-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/2/23 06:41, Richard Henderson wrote: > Here it is not trivial to notice first initialization, so explicitly > zero the temps. Use an array for the output, rather than separate > tcg_rd/tcg_rd_hi variables. > > Fixes a bug by adding a missing clear_vec_high. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 16aa71451c..02a61aa8b7 100644 > --- a/target/arm/translate-a64.c > +++ b/target/arm/translate-a64.c > @@ -12003,22 +12003,26 @@ static void handle_rev(DisasContext *s, int opcode, bool u, > int esize = 8 << size; > int elements = dsize / esize; > TCGv_i64 tcg_rn = tcg_temp_new_i64(); > - TCGv_i64 tcg_rd = tcg_const_i64(0); > - TCGv_i64 tcg_rd_hi = tcg_const_i64(0); > + TCGv_i64 tcg_rd[2]; > + > + for (i = 0; i < 2; i++) { > + tcg_rd[i] = tcg_temp_new_i64(); > + tcg_gen_movi_i64(tcg_rd[i], 0); > + } > > for (i = 0; i < elements; i++) { > int e_rev = (i & 0xf) ^ revmask; > - int off = e_rev * esize; > + int w = (e_rev * esize) / 64; > + int o = (e_rev * esize) % 64; > + > read_vec_element(s, tcg_rn, rn, i, size); > - if (off >= 64) { > - tcg_gen_deposit_i64(tcg_rd_hi, tcg_rd_hi, > - tcg_rn, off - 64, esize); > - } else { > - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_rn, off, esize); > - } > + tcg_gen_deposit_i64(tcg_rd[w], tcg_rd[w], tcg_rn, o, esize); > } > - write_vec_element(s, tcg_rd, rd, 0, MO_64); > - write_vec_element(s, tcg_rd_hi, rd, 1, MO_64); > + > + for (i = 0; i < 2; i++) { > + write_vec_element(s, tcg_rd[i], rd, i, MO_64); > + } Preferably splitting the bugfix in a preliminary patch, Reviewed-by: Philippe Mathieu-Daudé > + clear_vec_high(s, true, rd); > } > } >