From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07D54C3ABB0 for ; Mon, 5 May 2025 12:30:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uBuxB-0001oK-69; Mon, 05 May 2025 08:29:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBux6-0001nm-F8 for qemu-devel@nongnu.org; Mon, 05 May 2025 08:29:45 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uBux4-0001bx-5d for qemu-devel@nongnu.org; Mon, 05 May 2025 08:29:44 -0400 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-73c17c770a7so6068022b3a.2 for ; Mon, 05 May 2025 05:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746448180; x=1747052980; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TRdOlQiVHaiwUYAV1edB+DxcKZbO8etBkyN+zT5IlZY=; b=lZQCFBU4EKFVUmlmhb2w7RncQhLocB+0zIdcBB38Ef3zO3JqcdHJCaxqI+MQaQT87M d2FYzi5Nzhk57M6umm4/O/j+7jgwCxmKZmXLdOPs9l9QVM+inOpTUxfJXgeI+z5awJW9 gm2Ev49OLt1SE+H6Xzc/qtiTL7xycpngyUZ3KhLfmZP1Vv1oi0qt/ds3QZfYaM3thRQC eNjdD0FqHxR+scucxZ5WY8Bx349+PMUZgHci6FM/S5Gi0gYJxqIe/nPZQ1IlArCm9qNS Ti8WKfhGXdpZ62FFfk5RKXtl/vYiEUJBgRH1gCkWqz4BlSAakz2VNgll10xgtNljO1V1 ZgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746448180; x=1747052980; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TRdOlQiVHaiwUYAV1edB+DxcKZbO8etBkyN+zT5IlZY=; b=S3O9Mex0mME1kp4bieZRxqMSrl0xypZd2YWB8QeQ+QjnP99HXMJuevohdHoUdtdhDl M9C9ebiWtZAR7BUUIs5rfY2CVO96MGq1Uk/Ku/9blYshzuH/mtpMFg1gtrWWu972ZVLD qjAEFAQtLvu0WD1YsT2ePfZ4FQk+2iujbZbrZ21MZEmvxOo/2j0ab32mSkmzHdMUsROk GEPWEeXTb1ucer9Cw/VBY0eL9dDrDBFFL0+7kZyJRb9aPxvJCEyEcz/FntcTLMRlsQ8k ipHIqIDyRw6rqtOKKXLV3XbvD6/PCaCxV/r09XRNe6nN4lrXGIhZImISTaBTa33eykPp /ruA== X-Forwarded-Encrypted: i=1; AJvYcCWUbwG2MuV/my9LheH3aqjMIUjn/URhLBoaCD4BfAS9b2hKLrfLYXO4sHLSMLQR4HxjuGFVIiIqyjet@nongnu.org X-Gm-Message-State: AOJu0YzugKDDxmm8n/FkMtes24Oy/yCFl8CJMsFO9/TpzYQvLdBFTtdb 0J9A17oW7k6VaRtfZFAQTS1BbMtHfLOKtJdeHX6Iw6smXvmH2XNAZicPbSbY5gA= X-Gm-Gg: ASbGncueGFxRypHR9+7iDCSHxJGFhRqJEv1bSIyVYYVk9HyTWmOAI71qkHXEEM2bSCr edMRUyF7kIB6SiAl/9l2pgGr/JwGlnziDwfyCvJDl8cQqoXqViBwjCuk2WI6SmUex/j1DzLSZvg TbV7W4ivTSYPGIcyI04TkZJ8y/1K9j6KwxvDHSJQRxdiAwPcMMhTuT0lAhOw7czCfbhR76x5VXe wvw4OJhEaW0UVK6IBCD0cgHEWuACoZ2fwMqvVJLsauK6Q7t+WQ+SW5b0774jl2AROVFF2X27Ba/ 5Z8iAAZixfERNgKBFQIVeBpxzxw4M40PnxXq5nXyQmtjge3IjWvupDTOpD8NR2kYDW8TVL65EKD rs2c9v+8g+L4R2b97GqQ= X-Google-Smtp-Source: AGHT+IHc3Z3O0hTQrEXnjphhgDXAr0SqxcxJ7DQOJKbO06UPKn9yBeA6LAglX8tAVy1f8tQlD1iVAg== X-Received: by 2002:a05:6a00:8f0c:b0:736:5b85:a911 with SMTP id d2e1a72fcca58-7406f0bd9c7mr10908215b3a.8.1746448180316; Mon, 05 May 2025 05:29:40 -0700 (PDT) Received: from ?IPV6:2804:7f0:b400:8604:7950:93ed:53e9:9290? ([2804:7f0:b400:8604:7950:93ed:53e9:9290]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74058d7ad7asm6882301b3a.11.2025.05.05.05.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 05:29:39 -0700 (PDT) Message-ID: <6523849b-b44c-4176-ba5f-78a606621eb6@linaro.org> Date: Mon, 5 May 2025 09:29:36 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hw/acpi/pcihp: Fix typo in function name To: eric.auger@redhat.com, qemu-devel@nongnu.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= Cc: qemu-trivial@nongnu.org, philmd@linaro.org References: <20250504215639.54860-10-gustavo.romero@linaro.org> Content-Language: en-US From: Gustavo Romero In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=gustavo.romero@linaro.org; helo=mail-pf1-x442.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Eric, On 5/5/25 04:13, Eric Auger wrote: > > > On 5/4/25 11:56 PM, Gustavo Romero wrote: >> Fix typo in QEMU's ACPI PCI hotplug API function name that checks >> whether a given bus is hotplug-capable. >> >> Signed-off-by: Gustavo Romero > Reviewed-by: Eric Auger > > For awareness, there is a similar typo in pci-port. > see > https://lore.kernel.org/all/20250428102628.378046-2-eric.auger@redhat.com/ hmm it's unfortunate that I was about to publish a series to exactly enable the APCI PCI hotplug on ARM. Next time I should try to sync better with Red Hat folks on the work fronts... I've skimmed through your RFC and it seems to be doing mostly of what I was doing for my series, so I'll reviewed it formally today, it should be quick. Anyways, thanks for the heads up. Cheers, Gustavo > another trivial indentation fix in generic_event_device.c > https://lore.kernel.org/all/20250428102628.378046-3-eric.auger@redhat.com/ > > Eric > > > > >> --- >> hw/acpi/acpi-pci-hotplug-stub.c | 2 +- >> hw/acpi/ich9.c | 2 +- >> hw/acpi/pcihp.c | 2 +- >> hw/acpi/piix4.c | 2 +- >> include/hw/acpi/pcihp.h | 2 +- >> 5 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/hw/acpi/acpi-pci-hotplug-stub.c b/hw/acpi/acpi-pci-hotplug-stub.c >> index b67b4a92da..b7bc6e40a1 100644 >> --- a/hw/acpi/acpi-pci-hotplug-stub.c >> +++ b/hw/acpi/acpi-pci-hotplug-stub.c >> @@ -34,7 +34,7 @@ void acpi_pcihp_reset(AcpiPciHpState *s) >> { >> } >> >> -bool acpi_pcihp_is_hotpluggbale_bus(AcpiPciHpState *s, BusState *bus) >> +bool acpi_pcihp_is_hotpluggable_bus(AcpiPciHpState *s, BusState *bus) >> { >> return true; >> } >> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c >> index c7a735bf64..a07c9d115b 100644 >> --- a/hw/acpi/ich9.c >> +++ b/hw/acpi/ich9.c >> @@ -570,7 +570,7 @@ void ich9_pm_device_unplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, >> bool ich9_pm_is_hotpluggable_bus(HotplugHandler *hotplug_dev, BusState *bus) >> { >> ICH9LPCState *lpc = ICH9_LPC_DEVICE(hotplug_dev); >> - return acpi_pcihp_is_hotpluggbale_bus(&lpc->pm.acpi_pci_hotplug, bus); >> + return acpi_pcihp_is_hotpluggable_bus(&lpc->pm.acpi_pci_hotplug, bus); >> } >> >> void ich9_pm_ospm_status(AcpiDeviceIf *adev, ACPIOSTInfoList ***list) >> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c >> index 5f79c9016b..aac90013d4 100644 >> --- a/hw/acpi/pcihp.c >> +++ b/hw/acpi/pcihp.c >> @@ -371,7 +371,7 @@ void acpi_pcihp_device_unplug_request_cb(HotplugHandler *hotplug_dev, >> acpi_send_event(DEVICE(hotplug_dev), ACPI_PCI_HOTPLUG_STATUS); >> } >> >> -bool acpi_pcihp_is_hotpluggbale_bus(AcpiPciHpState *s, BusState *bus) >> +bool acpi_pcihp_is_hotpluggable_bus(AcpiPciHpState *s, BusState *bus) >> { >> Object *o = OBJECT(bus->parent); >> >> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c >> index b16d45f03e..d98b80df6d 100644 >> --- a/hw/acpi/piix4.c >> +++ b/hw/acpi/piix4.c >> @@ -406,7 +406,7 @@ static bool piix4_is_hotpluggable_bus(HotplugHandler *hotplug_dev, >> BusState *bus) >> { >> PIIX4PMState *s = PIIX4_PM(hotplug_dev); >> - return acpi_pcihp_is_hotpluggbale_bus(&s->acpi_pci_hotplug, bus); >> + return acpi_pcihp_is_hotpluggable_bus(&s->acpi_pci_hotplug, bus); >> } >> >> static void piix4_pm_machine_ready(Notifier *n, void *opaque) >> diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h >> index ac21a95913..a97904bada 100644 >> --- a/include/hw/acpi/pcihp.h >> +++ b/include/hw/acpi/pcihp.h >> @@ -58,7 +58,7 @@ typedef struct AcpiPciHpState { >> void acpi_pcihp_init(Object *owner, AcpiPciHpState *, PCIBus *root, >> MemoryRegion *io, uint16_t io_base); >> >> -bool acpi_pcihp_is_hotpluggbale_bus(AcpiPciHpState *s, BusState *bus); >> +bool acpi_pcihp_is_hotpluggable_bus(AcpiPciHpState *s, BusState *bus); >> void acpi_pcihp_device_pre_plug_cb(HotplugHandler *hotplug_dev, >> DeviceState *dev, Error **errp); >> void acpi_pcihp_device_plug_cb(HotplugHandler *hotplug_dev, AcpiPciHpState *s, >