From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Marco Liebel <quic_mliebel@quicinc.com>, qemu-devel@nongnu.org
Cc: Taylor Simpson <tsimpson@quicinc.com>
Subject: Re: [PATCH v2] Use f-strings in python scripts
Date: Wed, 15 Mar 2023 13:15:37 +0100 [thread overview]
Message-ID: <652c9544-cefe-3d1b-bfd2-8ce41fb8555c@linaro.org> (raw)
In-Reply-To: <881540e6-5720-268f-6141-c99f3663c2fa@linaro.org>
On 15/3/23 08:46, Philippe Mathieu-Daudé wrote:
> On 14/3/23 22:24, Marco Liebel wrote:
>> Replace python 2 format string with f-strings
>>
>> Signed-off-by: Marco Liebel <quic_mliebel@quicinc.com>
>> ---
>> target/hexagon/gen_analyze_funcs.py | 115 ++++-----
>> target/hexagon/gen_helper_funcs.py | 54 ++--
>> target/hexagon/gen_helper_protos.py | 10 +-
>> target/hexagon/gen_idef_parser_funcs.py | 8 +-
>> target/hexagon/gen_op_attribs.py | 4 +-
>> target/hexagon/gen_op_regs.py | 10 +-
>> target/hexagon/gen_opcodes_def.py | 2 +-
>> target/hexagon/gen_printinsn.py | 14 +-
>> target/hexagon/gen_shortcode.py | 2 +-
>> target/hexagon/gen_tcg_func_table.py | 2 +-
>> target/hexagon/gen_tcg_funcs.py | 317 +++++++++++-------------
>> target/hexagon/hex_common.py | 4 +-
>> 12 files changed, 243 insertions(+), 299 deletions(-)
>
> Preferably unifying style using single quote (') first:
Scratch that preference (or replace by "preferably following
black format", per
https://lore.kernel.org/qemu-devel/ZBGo8WNlnRZUGYJZ@redhat.com/).
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-03-15 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:24 [PATCH v2] Use f-strings in python scripts Marco Liebel
2023-03-15 7:46 ` Philippe Mathieu-Daudé
2023-03-15 12:15 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652c9544-cefe-3d1b-bfd2-8ce41fb8555c@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mliebel@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).