qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] linux-user: avoid treading on gprof's SIGPROF signals
Date: Thu, 9 May 2019 19:08:25 +0200	[thread overview]
Message-ID: <652f7793-8c6c-7fce-c099-41c2d00b1346@vivier.eu> (raw)
In-Reply-To: <20190502145846.26226-1-alex.bennee@linaro.org>

On 02/05/2019 16:58, Alex Bennée wrote:
> The guest tends to get confused when it receives signals it doesn't
> know about. Given the gprof magic has also set up it's own handler we
> would do well to avoid stomping on it as well.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   linux-user/signal.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index e2c0b37173..44b2d3b35a 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -508,6 +508,11 @@ void signal_init(void)
>       act.sa_flags = SA_SIGINFO;
>       act.sa_sigaction = host_signal_handler;
>       for(i = 1; i <= TARGET_NSIG; i++) {
> +#ifdef TARGET_GPROF
> +        if (i == SIGPROF) {
> +            continue;
> +        }
> +#endif
>           host_sig = target_to_host_signal(i);
>           sigaction(host_sig, NULL, &oact);
>           if (oact.sa_sigaction == (void *)SIG_IGN) {
> 

Applied to my linux-user branch.

Thanks,
Laurent


  parent reply	other threads:[~2019-05-09 17:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02  9:27 [Qemu-devel] [PATCH] linux-user: fix GPROF build failure Alex Bennée
2019-05-02  9:27 ` Alex Bennée
2019-05-02 10:14 ` Laurent Desnogues
2019-05-02 10:14   ` Laurent Desnogues
2019-05-02 14:50   ` Alex Bennée
2019-05-02 14:50     ` Alex Bennée
2019-05-02 14:58     ` [Qemu-devel] [PATCH] linux-user: avoid treading on gprof's SIGPROF signals Alex Bennée
2019-05-02 14:58       ` Alex Bennée
2019-05-02 16:14       ` Laurent Vivier
2019-05-02 16:14         ` Laurent Vivier
2019-05-02 16:27         ` Laurent Desnogues
2019-05-02 16:27           ` Laurent Desnogues
2019-05-02 16:33           ` Laurent Vivier
2019-05-02 16:33             ` Laurent Vivier
2019-05-09 17:08       ` Laurent Vivier [this message]
2019-05-09 17:08 ` [Qemu-devel] [PATCH] linux-user: fix GPROF build failure Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=652f7793-8c6c-7fce-c099-41c2d00b1346@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).