From: Laurent Vivier <laurent@vivier.eu>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
sw@weilnetz.de, armbru@redhat.com
Subject: Re: [PATCH v2] mingw: fix error __USE_MINGW_ANSI_STDIO redefined
Date: Mon, 12 Oct 2020 17:17:06 +0200 [thread overview]
Message-ID: <65366aa1-f521-0980-ed63-0fa3daaf6449@vivier.eu> (raw)
In-Reply-To: <20201008165953.884599-1-marcandre.lureau@redhat.com>
Le 08/10/2020 à 18:59, marcandre.lureau@redhat.com a écrit :
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Always put osdep.h first, and remove redundant stdlib.h include.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> migration/dirtyrate.c | 3 ++-
> tests/test-bitmap.c | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 68577ef250..47f761e67a 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -10,8 +10,9 @@
> * See the COPYING file in the top-level directory.
> */
>
> -#include <zlib.h>
> #include "qemu/osdep.h"
> +
> +#include <zlib.h>
> #include "qapi/error.h"
> #include "cpu.h"
> #include "qemu/config-file.h"
> diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c
> index 2f5b71458a..8db4f67883 100644
> --- a/tests/test-bitmap.c
> +++ b/tests/test-bitmap.c
> @@ -8,7 +8,6 @@
> * Author: Peter Xu <peterx@redhat.com>
> */
>
> -#include <stdlib.h>
> #include "qemu/osdep.h"
> #include "qemu/bitmap.h"
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2020-10-12 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 16:59 [PATCH v2] mingw: fix error __USE_MINGW_ANSI_STDIO redefined marcandre.lureau
2020-10-08 17:09 ` Peter Maydell
2020-10-08 17:25 ` Stefan Weil
2020-10-08 17:42 ` Philippe Mathieu-Daudé
2020-10-12 15:17 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65366aa1-f521-0980-ed63-0fa3daaf6449@vivier.eu \
--to=laurent@vivier.eu \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).