From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/2] target/ppc: Make divd[u] handler method decodetree compatible
Date: Mon, 12 Aug 2024 19:08:47 +1000 [thread overview]
Message-ID: <653ae871-1fda-428c-98f3-0f7e6bb28f15@linaro.org> (raw)
In-Reply-To: <20240812085841.1583-3-iii@linux.ibm.com>
On 8/12/24 18:53, Ilya Leoshkevich wrote:
> This is like commit 86e6202a57b1 ("target/ppc: Make divw[u] handler
> method decodetree compatible."), but for gen_op_arith_divd().
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> target/ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 02c810e8848..5a352cdad1b 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -1823,7 +1823,7 @@ static inline void gen_op_arith_divd(DisasContext *ctx, TCGv ret,
> tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
> }
>
> - if (unlikely(Rc(ctx->opcode) != 0)) {
> + if (unlikely(compute_rc0)) {
> gen_set_Rc0(ctx, ret);
> }
> }
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-08-12 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 8:53 [PATCH v2 0/2] target/ppc: Make divd[u] handler method decodetree compatible Ilya Leoshkevich
2024-08-12 8:53 ` [PATCH v2 1/2] target/ppc: Set ctx->opcode for decode_insn32() Ilya Leoshkevich
2024-08-12 8:53 ` [PATCH v2 2/2] target/ppc: Make divd[u] handler method decodetree compatible Ilya Leoshkevich
2024-08-12 9:08 ` Richard Henderson [this message]
2024-08-12 14:03 ` Philippe Mathieu-Daudé
2024-09-18 9:56 ` PING: [PATCH v2 0/2] " Ilya Leoshkevich
2024-10-08 5:16 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653ae871-1fda-428c-98f3-0f7e6bb28f15@linaro.org \
--to=richard.henderson@linaro.org \
--cc=danielhb413@gmail.com \
--cc=iii@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).