From: David Hildenbrand <david@redhat.com>
To: David Miller <dmiller423@gmail.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org, thuth@redhat.com
Cc: pasic@linux.ibm.com, borntraeger@linux.ibm.com,
farman@linux.ibm.com, cohuck@redhat.com,
richard.henderson@linaro.org
Subject: Re: [PATCH v3 3/3] s390x/tcg/tests: Tests for Miscellaneous-Instruction-Extensions Facility 3
Date: Wed, 16 Feb 2022 10:17:04 +0100 [thread overview]
Message-ID: <65402899-e2ad-0a59-e77a-07f2f8ca4ff2@redhat.com> (raw)
In-Reply-To: <b69367a6-7744-6dbf-c370-3019bd66965c@gmail.com>
On 15.02.22 21:27, David Miller wrote:
> tests/tcg/s390x/mie3-compl.c: [N]*K instructions
> tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction
> tests/tcg/s390x/mie3-sel.c: SELECT instruction
>
> Signed-off-by: David Miller <dmiller423@gmail.com>
> ---
> tests/tcg/s390x/Makefile.target | 2 +-
> tests/tcg/s390x/mie3-compl.c | 56 +++++++++++++++++++++++++++++++++
> tests/tcg/s390x/mie3-mvcrl.c | 31 ++++++++++++++++++
> tests/tcg/s390x/mie3-sel.c | 42 +++++++++++++++++++++++++
> 4 files changed, 130 insertions(+), 1 deletion(-)
> create mode 100644 tests/tcg/s390x/mie3-compl.c
> create mode 100644 tests/tcg/s390x/mie3-mvcrl.c
> create mode 100644 tests/tcg/s390x/mie3-sel.c
>
> diff --git a/tests/tcg/s390x/Makefile.target
> b/tests/tcg/s390x/Makefile.target
> index 1a7238b4eb..16b9d45307 100644
> --- a/tests/tcg/s390x/Makefile.target
> +++ b/tests/tcg/s390x/Makefile.target
> @@ -1,6 +1,6 @@
> S390X_SRC=$(SRC_PATH)/tests/tcg/s390x
> VPATH+=$(S390X_SRC)
> -CFLAGS+=-march=zEC12 -m64
> +CFLAGS+=-march=z15 -m64
Unfortunately, this makes our docker builds unhappy -- fail. I assume the
compiler in the container is outdated.
$ make run-tcg-tests-s390x-linux-user
changing dir to build for make "run-tcg-tests-s390x-linux-user"...
make[1]: Entering directory '/home/dhildenb/git/qemu/build'
GIT ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc capstone slirp
BUILD debian10
BUILD debian-s390x-cross
BUILD TCG tests for s390x-linux-user
CHECK debian10
CHECK debian-s390x-cross
BUILD s390x-linux-user guest-tests with docker qemu/debian-s390x-cross
s390x-linux-gnu-gcc: error: unrecognized argument in option '-march=z15'
s390x-linux-gnu-gcc: note: valid arguments to '-march=' are: arch10 arch11 arch12 arch3 arch5 arch6 arch7 arch8 arch9 g5 g6 native z10 z13 z14 z196 z9-109 z9-ec z900 z990 zEC12; did you mean 'z10'?
Maybe debian11 could, work.
@Thomas do you have any idea if we could get this to work with
'-march=z15' or should we work around that by manually encoding
the relevant instructions instead?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-02-16 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 20:27 [PATCH v3 3/3] s390x/tcg/tests: Tests for Miscellaneous-Instruction-Extensions Facility 3 David Miller
2022-02-16 9:17 ` David Hildenbrand [this message]
2022-02-16 9:28 ` Christian Borntraeger
2022-02-16 9:30 ` David Hildenbrand
2022-02-16 9:43 ` Thomas Huth
2022-02-16 9:53 ` David Hildenbrand
2022-02-16 14:19 ` Alex Bennée
2022-02-16 14:27 ` David Hildenbrand
2022-02-16 9:57 ` David Hildenbrand
2022-02-16 10:58 ` David Hildenbrand
2022-02-16 11:05 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65402899-e2ad-0a59-e77a-07f2f8ca4ff2@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=dmiller423@gmail.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).