From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4274AC61DA4 for ; Mon, 6 Mar 2023 10:53:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZ8TE-0007nj-F4; Mon, 06 Mar 2023 05:53:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZ8TC-0007m3-35; Mon, 06 Mar 2023 05:53:30 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZ8TA-0001Tx-Ej; Mon, 06 Mar 2023 05:53:29 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3269aJAo031863; Mon, 6 Mar 2023 10:53:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=VSRFycv6EmsVky2itRCebapdHWdMwy2mqOmL20tJ+h0=; b=qpW+jIxvD7e+1uXEdlye/vudfRgFEr6kyyQA4gjZpIvk6MoqM2/3zAVDCzWgU+2t7kMw ly91ivf+tPqQ7Lt1Vr7P0vhY2VkvCbNKI38qNuHSoXhZtRn+hIQnL+JFi/5uEZimdDgw VV7r8J08CkTIQDfNTQCuk1agaATWWb7NuPFmLmuRDZAN6/4T+ZfGcLo40G3n3cgUeqIh 6NaHSlWHy/rNJJm1mFeBR9HopjPFAjwnAPEi0fSCmtNoi3Y2IVuvOm2KJskHFsG7E3Zt 3LsknA4V6zXkMxbWDJ+lpEpqSfb8xc5LxmddYODd35CSjCSrLFGiy0kdvb6nKdRbjXm7 /Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p4u1jdg42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 10:53:25 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 326Ans9S016898; Mon, 6 Mar 2023 10:53:24 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p4u1jdg3a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 10:53:24 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 325K7tv9005745; Mon, 6 Mar 2023 10:53:22 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3p41brak4e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 10:53:22 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 326ArJnp28705260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Mar 2023 10:53:19 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D10AF20043; Mon, 6 Mar 2023 10:53:19 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC39C2004D; Mon, 6 Mar 2023 10:53:18 +0000 (GMT) Received: from [9.171.79.58] (unknown [9.171.79.58]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Mar 2023 10:53:18 +0000 (GMT) Message-ID: <6551d845ae434dd73758a16d7982146874a852f1.camel@linux.ibm.com> Subject: Re: [PATCH v3 16/20] target/s390x: Remove assert vs g_in2 From: Ilya Leoshkevich To: Richard Henderson , qemu-devel@nongnu.org Cc: David Hildenbrand , Thomas Huth , qemu-s390x@nongnu.org Date: Mon, 06 Mar 2023 11:53:18 +0100 In-Reply-To: <20230304181900.1097116-17-richard.henderson@linaro.org> References: <20230304181900.1097116-1-richard.henderson@linaro.org> <20230304181900.1097116-17-richard.henderson@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: IXi1ohw8rr1LRYBbWVHaVcO-loJZkH5p X-Proofpoint-ORIG-GUID: xeiFKPccSCSMuhVdcY6ugYGPz9yaGuXz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-06_03,2023-03-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 clxscore=1015 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=943 malwarescore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303060091 Received-SPF: pass client-ip=148.163.156.1; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, 2023-03-04 at 10:18 -0800, Richard Henderson wrote: > These were trying to determine if o->in2 was available for > use as a temporary.=C2=A0 It's better to just allocate a new one. >=20 > Signed-off-by: Richard Henderson > --- > Cc: David Hildenbrand > Cc: Ilya Leoshkevich > Cc: Thomas Huth > Cc: qemu-s390x@nongnu.org > --- > =C2=A0target/s390x/tcg/translate.c | 20 ++++++++++---------- > =C2=A01 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Ilya Leoshkevich