From: Yan Vugenfirer <yvugenfi@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package
Date: Thu, 4 Jun 2015 18:00:11 +0300 [thread overview]
Message-ID: <6552ED9F-467D-4FE5-A338-9CE703DCE5E0@redhat.com> (raw)
In-Reply-To: <554A21B6.4070302@redhat.com>
> On May 6, 2015, at 5:14 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
>
> On 06/05/2015 13:57, Yossi Hindin wrote:
>> The second version of commits's set take into account Paolo Bonzini remarks.
>>
>> Typo in WXS file fixed, QEMU GA-related CLI options renamed, '--enable-guest-agent-msi'/
>> '--disable-guest-agent-msi' processing logic changed so that MSI build is configured
>> by default, unless some prerequisite is missing and MinGW DLL path variable is computed
>> together with all QEMU GA MSI variables.
>>
>> Also, I've slightly changed Makefile structure so that if MSI build was not configured,
>> Makefile prints suitable message.
>>
>>
>> Yossi Hindin (4):
>> qemu-ga: adding vss-[un]install options
>> qemu-ga: debug printouts to help troubleshoot installation
>> qemu-ga: Introduce Windows MSI script
>> qemu-ga: Building Windows MSI installation with configure/Makefile
>>
>> Makefile | 24 +++++++-
>> configure | 66 +++++++++++++++++++++
>> qga/channel-win32.c | 2 +-
>> qga/commands-win32.c | 1 +
>> qga/installer/qemu-ga.wxs | 145 ++++++++++++++++++++++++++++++++++++++++++++++
>> qga/main.c | 10 +++-
>> 6 files changed, 245 insertions(+), 3 deletions(-)
>> create mode 100644 qga/installer/qemu-ga.wxs
>>
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
Ping.
next prev parent reply other threads:[~2015-06-04 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 11:57 [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package Yossi Hindin
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 1/4] qemu-ga: adding vss-[un]install options Yossi Hindin
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 2/4] qemu-ga: debug printouts to help troubleshoot installation Yossi Hindin
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 3/4] qemu-ga: Introduce Windows MSI script Yossi Hindin
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile Yossi Hindin
2015-05-06 14:14 ` [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package Paolo Bonzini
2015-06-04 15:00 ` Yan Vugenfirer [this message]
2015-06-17 13:25 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6552ED9F-467D-4FE5-A338-9CE703DCE5E0@redhat.com \
--to=yvugenfi@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).