From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Laszlo Ersek <lersek@redhat.com>,
qemu devel list <qemu-devel@nongnu.org>
Cc: virtio-fs@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] vhost-user-fs: add the "bootindex" property
Date: Mon, 11 Jan 2021 11:07:03 +0100 [thread overview]
Message-ID: <656f8775-aeb4-3feb-0373-5f9024c6c7aa@de.ibm.com> (raw)
In-Reply-To: <d9f913fa-9d1b-8d52-d98b-ae558e4406ca@redhat.com>
On 11.01.21 11:05, Laszlo Ersek wrote:
> On 01/11/21 10:46, Christian Borntraeger wrote:
>>
>>
>> On 04.01.21 14:24, Laszlo Ersek wrote:
>>> virtio-fs qualifies as a bootable device minimally under OVMF, but
>>> currently the necessary "bootindex" property is missing (fw_cfg kernel
>>> boot notwithstanding).
>>>
>>> Add the property. For completeness, add it to the CCW device as well;
>>> other virtio-ccw devices seem to have "bootindex" properties too.
>>
>> Currently we do not have boot support for virtiofs on s390x (ccw)
>> Not sure if it is better if we should add the property now or whenever
>> boot support is implemented.
>> As of today we do have bootindex for block and net. Maybe it is better
>> to defer bootindex for virtio-fs-ccw until we can boot from it? In
>> that way management software can detect if this is bootable or not?
>
> Sure, I can drop the "vhost-user-fs-ccw.c hunk".
>
> (I guess I could even lift the property itself (replacing the alias) to
> "vhost-user-fs-pci.c", for now -- what's everyone's take on that?)
Keep it as is. This would simplify a later addition to ccw.
next prev parent reply other threads:[~2021-01-11 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 13:24 [PATCH] vhost-user-fs: add the "bootindex" property Laszlo Ersek
2021-01-11 8:50 ` Laszlo Ersek
2021-01-11 9:46 ` Christian Borntraeger
2021-01-11 10:05 ` Laszlo Ersek
2021-01-11 10:07 ` Christian Borntraeger [this message]
2021-01-11 16:16 ` Laszlo Ersek
2021-01-11 16:22 ` Cornelia Huck
2021-01-11 16:32 ` Laszlo Ersek
2021-01-11 17:38 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656f8775-aeb4-3feb-0373-5f9024c6c7aa@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).