From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Li Zhijian <lizhijian@fujitsu.com>,
jonathan.cameron@huawei.com, fan.ni@samsung.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/cxl: Fix opaque type interpret wrongly
Date: Fri, 13 Oct 2023 10:52:36 +0200 [thread overview]
Message-ID: <657c8046-04f5-a131-cfa8-aeb493caf760@linaro.org> (raw)
In-Reply-To: <20231013015515.23647-1-lizhijian@fujitsu.com>
On 13/10/23 03:55, Li Zhijian wrote:
> void cxl_component_register_block_init(Object *obj,
> CXLComponentState *cxl_cstate,
> const char *type)
> {
> ComponentRegisters *cregs = &cxl_cstate->crb;
> ...
> memory_region_init_io(&cregs->cache_mem, obj, &cache_mem_ops, cregs,
> ".cache_mem", CXL2_COMPONENT_CM_REGION_SIZE);
>
> Obviously, opaque should be pointer to ComponentRegisters.
> Fortunately, cregs is the first member of cxl_state, so their values are
> the same.
>
> Fixes: 9e58f52d3f8 ("hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)")
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> hw/cxl/cxl-component-utils.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-10-13 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 1:55 [PATCH] hw/cxl: Fix opaque type interpret wrongly Li Zhijian
2023-10-13 8:52 ` Philippe Mathieu-Daudé [this message]
2023-10-18 8:27 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657c8046-04f5-a131-cfa8-aeb493caf760@linaro.org \
--to=philmd@linaro.org \
--cc=fan.ni@samsung.com \
--cc=jonathan.cameron@huawei.com \
--cc=lizhijian@fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).