From: Thomas Huth <thuth@redhat.com>
To: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image
Date: Sat, 30 May 2020 19:25:03 +0200 [thread overview]
Message-ID: <658ce012-150d-40ee-0689-0262971e20b4@redhat.com> (raw)
In-Reply-To: <CAHiYmc72cA9Va_JCbzq+E0M3wUuxedH2=BdE-YqAqWF8DBD_kA@mail.gmail.com>
On 30/05/2020 10.54, Aleksandar Markovic wrote:
> 18:44 Pet, 15.05.2020. Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> је написао/ла:
>>
>> Now that we can select the second serial console in the acceptance tests
>> (see commit 746f244d9720 "Allow to use other serial consoles than
> default"),
>> we can also test the sh4 image from the QEMU advent calendar 2018.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com <mailto:thuth@redhat.com>>
>> ---
>> I've split my original patch that also added yet another mips64 test...
>> I hope it's easier to review/ack/merge this way this only addresses
> sh4 here.
>>
>
> It makes sense to me, Thomas. If I were you, I would do the same.
>
> But, sorry, do you intend to send mips64 counterpart in future, or it is
> already sent, but I somehow missed it?
Hi Aleksandar,
I was planning to send a separate patch, but then I noticed that there
are already quite a lot of tests for the various flavors of the
mips-malta machine in tests/acceptance/boot_linux_console.py ... so I
currently doubt that the malta advent calendar image will add much value
here?
Thomas
next prev parent reply other threads:[~2020-05-30 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 16:43 [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image Thomas Huth
2020-05-30 8:02 ` Philippe Mathieu-Daudé
2020-05-30 8:54 ` Aleksandar Markovic
2020-05-30 17:25 ` Thomas Huth [this message]
2020-05-30 19:49 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658ce012-150d-40ee-0689-0262971e20b4@redhat.com \
--to=thuth@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosa@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).