From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Andrew Melnychenko <andrew@daynix.com>
Subject: Re: [PATCH v2 5/7] hw/net: report errors from failing to use eBPF RSS FDs
Date: Fri, 6 Sep 2024 12:09:42 +0200 [thread overview]
Message-ID: <658d7d65-04c6-4da2-a741-6e2635590fce@linaro.org> (raw)
In-Reply-To: <20240905181330.3657590-6-berrange@redhat.com>
On 5/9/24 20:13, Daniel P. Berrangé wrote:
> If the user/mgmt app passed in a set of pre-opened FDs for eBPF RSS,
> then it is expecting QEMU to use them. Any failure to do so must be
> considered a fatal error and propagated back up the stack, otherwise
> deployment mistakes will not be detectable in a prompt manner. When
> not using pre-opened FDs, then eBPF RSS is tried on a "best effort"
> basis only and thus fallback to software RSS is valid.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> hw/net/virtio-net.c | 41 +++++++++++++++++++++++++++++------------
> 1 file changed, 29 insertions(+), 12 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-09-06 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:13 [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 1/7] hw/net: fix typo s/epbf/ebpf/ in virtio-net Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 2/7] ebpf: drop redundant parameter checks in static methods Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 3/7] ebpf: improve error trace events Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 4/7] ebpf: add formal error reporting to all APIs Daniel P. Berrangé
2024-09-06 10:07 ` Philippe Mathieu-Daudé
2024-10-23 3:55 ` Jason Wang
2024-10-23 8:52 ` Daniel P. Berrangé
2024-09-05 18:13 ` [PATCH v2 5/7] hw/net: report errors from failing to use eBPF RSS FDs Daniel P. Berrangé
2024-09-06 10:09 ` Philippe Mathieu-Daudé [this message]
2024-09-05 18:13 ` [PATCH v2 6/7] ebpf: improve trace event coverage to all key operations Daniel P. Berrangé
2024-09-06 10:10 ` Philippe Mathieu-Daudé
2024-09-05 18:13 ` [PATCH v2 7/7] hw/net: improve tracing of eBPF RSS setup Daniel P. Berrangé
2024-09-06 10:12 ` Philippe Mathieu-Daudé
2024-09-06 9:57 ` [PATCH v2 0/7] Report fatal errors from failure with pre-opened eBPF RSS FDs Michael S. Tsirkin
2024-09-09 2:34 ` Jason Wang
2024-10-15 13:50 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658d7d65-04c6-4da2-a741-6e2635590fce@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@daynix.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).