From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, kraxel@redhat.com
Cc: ppandit@redhat.com, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size
Date: Wed, 31 Oct 2018 15:10:32 +0100 [thread overview]
Message-ID: <6596f2f5-01f4-6075-48c0-359134856284@redhat.com> (raw)
In-Reply-To: <154096215214.6332.16173638540950760088@015909e0f939>
Hi Gerd,
On 31/10/18 6:02, no-reply@patchew.org wrote:
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: fmops: fix off-by-one in AR_TABLE and DR_TABLE array size...
> ERROR: code indent should never use tabs
> #27: FILE: hw/audio/fmopl.h:75:
> +^Iint32_t AR_TABLE[76];^I/* atttack rate tables */$
Can you also fix "attack" when respinning?
>
> ERROR: code indent should never use tabs
> #28: FILE: hw/audio/fmopl.h:76:
> +^Iint32_t DR_TABLE[76];^I/* decay rate tables */$
>
> total: 2 errors, 0 warnings, 10 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
next prev parent reply other threads:[~2018-10-31 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 8:23 [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size Gerd Hoffmann
2018-10-30 8:45 ` Philippe Mathieu-Daudé
2018-10-31 5:02 ` no-reply
2018-10-31 14:10 ` Philippe Mathieu-Daudé [this message]
2018-11-12 13:18 ` Gerd Hoffmann
2018-11-21 10:49 ` P J P
2018-11-21 13:07 ` Gerd Hoffmann
2018-11-27 7:30 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6596f2f5-01f4-6075-48c0-359134856284@redhat.com \
--to=philmd@redhat.com \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).