Re: [RFC PATCH] util: split unix socket functions out of qemu-sockets

[Ilya Leoshkevich <iii@linux.ibm.com>]

Thanks for looking into this!

On 2025-05-20 17:57, Alex Bennée wrote:
> Since fccb744f41 (gdbstub: Try unlinking the unix socket before
> binding) we use the unix_listen() function from linux-user which
> causes complications when trying to build statically.

Should this be in Fixes: tag?

> Fix this by splitting the unix functions into its own file and doing
> the appropriate tweaks to the headers.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  include/qemu/sockets.h |   1 +
>  util/socket-helpers.h  |  17 ++++
>  util/qemu-sockets.c    | 199 +--------------------------------------
>  util/unix-sockets.c    | 207 +++++++++++++++++++++++++++++++++++++++++
>  util/meson.build       |   5 +-
>  5 files changed, 231 insertions(+), 198 deletions(-)
>  create mode 100644 util/socket-helpers.h
>  create mode 100644 util/unix-sockets.c

[...]

> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -1,5 +1,5 @@
>  /*
> - *  inet and unix socket functions for qemu
> + *  inet socket functions for qemu
>   *
>   *  (c) 2008 Gerd Hoffmann <kraxel@redhat.com>
>   *

Should we mention that static linking of this file is not supported?

With or without this:

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>