From: Alexander Graf <agraf@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: Stefan Weil <sw@weilnetz.de>, Richard Henderson <rth@twiddle.net>,
qemu-ppc@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code
Date: Tue, 4 Oct 2011 00:06:02 +0200 [thread overview]
Message-ID: <65EABF1C-407C-40C9-8638-7ACFA537A47A@suse.de> (raw)
In-Reply-To: <4E8A2E2C.2060004@freescale.com>
On 03.10.2011, at 23:50, Scott Wood wrote:
> On 10/03/2011 04:36 PM, Alexander Graf wrote:
>> With TCG, we're never executing guest code directly, but always go
>> through TCG to emulate it. So the only case where we actually need to
>> flush the icache is in TCG code generation, never outside, right?
>
> Right.
>
>> For KVM, I agree. We need some indication to flush the cache. But it
>> doesn't have to be done that complicated. We can simply do an inline
>> function that gets always called and has a few conditionals on when
>> to actually flush. That inline function could easily be a nop on
>> !ppc, though I'm not 100% sure that no other arch needs this.
>
> It's already an inline function that's a nop on !ppc. What
> simplification do you suggest?
Is flush_icache_range() always defined on all hosts with all compiler variants that QEMU supports? If not, we should have a small wrapper that explicitly makes it a nop on !ppc. CC'ing Paolo and Richard for clarification.
Alex
next prev parent reply other threads:[~2011-10-03 22:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 20:43 [Qemu-devel] Clean cache related code which was used only by PPC hosts Stefan Weil
2011-10-03 20:43 ` [Qemu-devel] [PATCH 1/2] linux-user: Remove unused code Stefan Weil
2011-10-03 21:12 ` Stefan Weil
2011-10-04 7:56 ` Peter Maydell
2011-10-05 8:26 ` Stefan Hajnoczi
2011-10-03 20:43 ` [Qemu-devel] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code Stefan Weil
2011-10-03 20:52 ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2011-10-03 21:10 ` Stefan Weil
2011-10-03 21:36 ` Alexander Graf
2011-10-03 21:50 ` Scott Wood
2011-10-03 22:06 ` Alexander Graf [this message]
2011-10-03 22:07 ` Scott Wood
2011-10-03 22:11 ` Alexander Graf
2011-10-03 21:40 ` Scott Wood
2011-10-03 21:43 ` Alexander Graf
2011-10-03 21:51 ` Scott Wood
2011-10-03 22:03 ` Alexander Graf
2011-10-04 6:06 ` Benjamin Herrenschmidt
2011-10-04 5:55 ` Stefan Weil
2011-10-04 6:29 ` Paolo Bonzini
2011-10-04 8:11 ` Peter Maydell
2011-10-04 15:44 ` Scott Wood
2011-10-03 23:12 ` [Qemu-devel] " malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65EABF1C-407C-40C9-8638-7ACFA537A47A@suse.de \
--to=agraf@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=scottwood@freescale.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).