From: "Cédric Le Goater" <clg@kaod.org>
To: Tan Siewert <tan@siewert.io>,
Jamin Lin <jamin_lin@aspeedtech.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>
Subject: Re: [PATCH v4] hw/misc/aspeed_scu: Handle AST2600 protection key registers correctly
Date: Fri, 27 Jun 2025 13:32:09 +0200 [thread overview]
Message-ID: <65a22a3c-1227-47b7-a001-dd98dac1191c@kaod.org> (raw)
In-Reply-To: <8d21f5e6-9188-4abf-8f97-5da3b585a892@siewert.io>
On 6/27/25 12:16, Tan Siewert wrote:
> On 20.06.25 03:23, Jamin Lin wrote:
>>
>>> Subject: Re: [PATCH v4] hw/misc/aspeed_scu: Handle AST2600 protection key
>>> registers correctly
>>>
>>> Jamin,
>>>
>>> On 6/19/25 10:53, Tan Siewert wrote:
>>>> The AST2600 SCU has two protection key registers (0x00 and 0x10) that
>>>> both need to be unlocked. (Un-)locking 0x00 modifies both protection
>>>> key registers, while modifying 0x10 only modifies itself.
>>>>
>>>> This commit updates the SCU write logic to reject writes unless both
>>>> protection key registers are unlocked, matching the behaviour of real
>>>> hardware.
>>>>
>>>> Signed-off-by: Tan Siewert <tan@siewert.io>
>>>
>>> Could you please resend your R-b ?
>>>
>>> Thanks,
>>>
>>> C.
>>>
>>>
>>
>> Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>
>>
>> Thanks-Jamin
>
> Cédric,
>
> Do you think this patch could be applied to aspeed-next?
I did a week ago.
https://github.com/legoater/qemu/commit/7b27524a27a3e835b2e6b725e1778950015cbb63
Thanks,
C.
prev parent reply other threads:[~2025-06-27 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 8:53 [PATCH v4] hw/misc/aspeed_scu: Handle AST2600 protection key registers correctly Tan Siewert
2025-06-19 11:58 ` Cédric Le Goater
2025-06-20 1:23 ` Jamin Lin
2025-06-27 10:16 ` Tan Siewert
2025-06-27 11:32 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a22a3c-1227-47b7-a001-dd98dac1191c@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=tan@siewert.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).