From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4846EE49A4 for ; Sun, 10 Sep 2023 23:30:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfTsN-0005kj-K4; Sun, 10 Sep 2023 19:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfTsL-0005jD-UX for qemu-devel@nongnu.org; Sun, 10 Sep 2023 19:29:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfTs6-0005fU-Br for qemu-devel@nongnu.org; Sun, 10 Sep 2023 19:29:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694388581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hAju71sftURmQHKQ3rbHJSgblwqG5zsGqkK+gjZHwE4=; b=QedcQoH53brnu7Mk3fPnJ4IQLDtzAYMskSjk8eEyvTTMj4W3CEbWHfwHRz8BIuEnCE+PD5 a+CS7wlQCOL6MVyfgheXEgKV2bdMCFRkdiIVU6CoswigCp60bMnVnsLsHUl2lfjpuw5Iux QqJtATAUCtov+0UGCd41hlKqdYXetUY= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-IOWUcE6-MS2wrRUgWKWcXw-1; Sun, 10 Sep 2023 19:29:39 -0400 X-MC-Unique: IOWUcE6-MS2wrRUgWKWcXw-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1bf75ca4e4fso45886035ad.0 for ; Sun, 10 Sep 2023 16:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694388579; x=1694993379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hAju71sftURmQHKQ3rbHJSgblwqG5zsGqkK+gjZHwE4=; b=mXWLFpTB9SG69tfD1i2Wy8pVtfqkhGSyxdgp3okI6cJgGLtS8Mxk3AkrttPSFEhkPP yx3xXUQ/IiSbcZwXCak8Vbtcj/nXLpEYggQVfgV9nl+7/nqMbUKDMPF+A6H4xrCJ0eWy QLpFxS2lONlicRg2kzXabpRyIVTq7l1rZZPpKInBP2fqWN0rkl+KSc8ZEDb6oSdbqg4P gM27x1nBtl5DIPdMANaCzFvygDmaTB5jFglJFtS8AYr0xSVfLTz4j+dUVv2z0Fqt0eAu E5Z4MEtxP3Q7f7YTDtBCaux+na0SazEYVf23vlZ6OuFqPhXQsoW534hniHb2GRsu7izR N2aQ== X-Gm-Message-State: AOJu0Ywv+p7G/o4ppcv5zybDyR1sPog9FOfVhAgw3BIGqk+WO3QJ6VKv OovZ5PpTwytJPpSPFhuYf8+bVBQuozLyPcS4EVH3ywaUcZ/pdH8yh7DSXp1T0jtC8JAueXfCNU3 J5JR1JIaNby0JsRo= X-Received: by 2002:a17:903:41d1:b0:1c0:afda:7707 with SMTP id u17-20020a17090341d100b001c0afda7707mr11855868ple.34.1694388578973; Sun, 10 Sep 2023 16:29:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhL+aLUjEVq1puflmFSoWlRj8SczWAVxcbFP99OmhZVveFvp/yr1E/E4FbM9pNv6815bAL+w== X-Received: by 2002:a17:903:41d1:b0:1c0:afda:7707 with SMTP id u17-20020a17090341d100b001c0afda7707mr11855826ple.34.1694388578576; Sun, 10 Sep 2023 16:29:38 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id iw7-20020a170903044700b001c3a7fbf96fsm1728421plb.216.2023.09.10.16.29.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 16:29:37 -0700 (PDT) Message-ID: <65ad3c9c-92ce-5b9f-9181-d466affaf32c@redhat.com> Date: Mon, 11 Sep 2023 09:29:23 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/4] target/alpha: Tidy up alpha_cpu_class_by_name() Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, David Hildenbrand Cc: Chris Wulff , David Gibson , qemu-s390x@nongnu.org, Weiwei Li , qemu-arm@nongnu.org, Mark Cave-Ayland , Jiaxun Yang , Yoshinori Sato , Richard Henderson , Marcel Apfelbaum , Max Filippov , Nicholas Piggin , Eduardo Habkost , Ilya Leoshkevich , Bastian Koppelmann , Greg Kurz , "Edgar E. Iglesias" , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Marek Vasut , Palmer Dabbelt , Michael Rolnik , Laurent Vivier , Peter Maydell , qemu-riscv@nongnu.org, Aurelien Jarno , Bin Meng , Xiaojuan Yang , Daniel Henrique Barboza , Aleksandar Rikalo , Artyom Tarasenko , Song Gao , Stafford Horne , Yanan Wang , Alistair Francis , Brian Cain , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Thomas Huth , Liu Zhiwei References: <20230908112235.75914-1-philmd@linaro.org> <20230908112235.75914-2-philmd@linaro.org> From: Gavin Shan In-Reply-To: <20230908112235.75914-2-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.473, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/8/23 21:22, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/alpha/cpu.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > Reviewed-by: Gavin Shan > diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c > index 270ae787b1..351ee2e9f2 100644 > --- a/target/alpha/cpu.c > +++ b/target/alpha/cpu.c > @@ -142,13 +142,10 @@ static ObjectClass *alpha_cpu_class_by_name(const char *cpu_model) > typename = g_strdup_printf(ALPHA_CPU_TYPE_NAME("%s"), cpu_model); > oc = object_class_by_name(typename); > g_free(typename); > - if (oc != NULL && object_class_is_abstract(oc)) { > - oc = NULL; > - } > > /* TODO: remove match everything nonsense */ > - /* Default to ev67; no reason not to emulate insns by default. */ > - if (!oc) { > + if (!oc || object_class_is_abstract(oc)) { > + /* Default to ev67; no reason not to emulate insns by default. */ > oc = object_class_by_name(ALPHA_CPU_TYPE_NAME("ev67")); > } >