Re: [PATCH v5 24/35] target/hexagon: Add sysemu TCG overrides

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 11/3/26 04:49, Brian Cain wrote:
> From: Brian Cain <bcain@quicinc.com>
> 
> Define TCG overrides for setprio(), crswap(,sgp{0,1,1:0}).
> 
> Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
> ---
>   target/hexagon/cpu_helper.h  | 18 ++++++++++++++++
>   target/hexagon/gen_tcg_sys.h | 40 ++++++++++++++++++++++++++++++++++++
>   target/hexagon/helper.h      |  1 +
>   target/hexagon/genptr.c      |  4 ++++
>   target/hexagon/op_helper.c   | 10 ++++++++-
>   target/hexagon/hex_common.py |  2 ++
>   target/hexagon/meson.build   | 13 ++++++------
>   7 files changed, 81 insertions(+), 7 deletions(-)
>   create mode 100644 target/hexagon/cpu_helper.h
>   create mode 100644 target/hexagon/gen_tcg_sys.h


> diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c
> index 327c233c01b..d9d84f05553 100644
> --- a/target/hexagon/op_helper.c
> +++ b/target/hexagon/op_helper.c
> @@ -19,9 +19,10 @@
>   #include "qemu/log.h"
>   #include "accel/tcg/cpu-ldst.h"
>   #include "accel/tcg/probe.h"
> +#include "qemu/main-loop.h"

"qemu/main-loop.h" doesn't seem used in this patch.

> +#include "cpu.h"
>   #include "exec/helper-proto.h"
>   #include "fpu/softfloat.h"
> -#include "cpu.h"
>   #include "internal.h"
>   #include "macros.h"
>   #include "sys_macros.h"
> @@ -31,6 +32,7 @@
>   #include "mmvec/mmvec.h"
>   #include "mmvec/macros.h"
>   #include "op_helper.h"
> +#include "cpu_helper.h"
>   #include "translate.h"
>   #ifndef CONFIG_USER_ONLY
>   #include "hexswi.h"
> @@ -1412,6 +1414,12 @@ uint64_t HELPER(greg_read_pair)(CPUHexagonState *env, uint32_t reg)
>   {
>       g_assert_not_reached();
>   }
> +
> +void HELPER(setprio)(CPUHexagonState *env, uint32_t thread, uint32_t prio)
> +{
> +    g_assert_not_reached();
> +}
> +
>   #endif