From: Dan Williams <dan.j.williams@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>, <qemu-devel@nongnu.org>,
<linux-cxl@vger.kernel.org>
Cc: <Jonathan.Cameron@huawei.com>, <dan.j.williams@intel.com>,
<dave@stgolabs.net>, <ira.weiny@intel.com>
Subject: Re: [RFC PATCH v2 2/6] cxl/core: introduce cxl_mem_report_poison()
Date: Fri, 29 Mar 2024 18:39:37 -0700 [thread overview]
Message-ID: <66076d597cd7b_19e029480@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20240329063614.362763-3-ruansy.fnst@fujitsu.com>
Shiyang Ruan wrote:
> If poison is detected(reported from cxl memdev), OS should be notified to
> handle it. So, introduce this helper function for later use:
> 1. translate DPA to HPA;
> 2. enqueue records into memory_failure's work queue;
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
This patch is too small, it needs the corresponding caller to make sense
of the proposed change.
> ---
>
> Currently poison injection from debugfs always create a 64-bytes-length
> record, which is fine. But the injection from qemu's QMP API:
> qmp_cxl_inject_poison() could create a poison record contains big length,
> which may cause many many times of calling memory_failure_queue().
> Though the MEMORY_FAILURE_FIFO_SIZE is 1 << 4, it seems not enougth.
What matters is what devices do in practice, the kernel should not be
worried about odd corner cases that only exist in QEMU injection
scenarios.
next prev parent reply other threads:[~2024-03-30 1:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 6:36 [RFC PATCH v2 0/6] cxl: add poison event handler Shiyang Ruan via
2024-03-29 6:36 ` [RFC PATCH v2 1/6] cxl/core: correct length of DPA field masks Shiyang Ruan via
2024-03-30 1:37 ` Dan Williams
2024-04-01 9:14 ` Shiyang Ruan via
2024-03-29 6:36 ` [RFC PATCH v2 2/6] cxl/core: introduce cxl_mem_report_poison() Shiyang Ruan via
2024-03-30 1:39 ` Dan Williams [this message]
2024-03-29 6:36 ` [RFC PATCH v2 3/6] cxl/core: add report option for cxl_mem_get_poison() Shiyang Ruan via
2024-03-30 1:50 ` Dan Williams
2024-04-03 14:56 ` Shiyang Ruan via
2024-04-04 13:46 ` Jonathan Cameron via
2024-03-29 6:36 ` [RFC PATCH v2 4/6] cxl/core: report poison when injecting from debugfs Shiyang Ruan via
2024-03-29 18:13 ` Alison Schofield
2024-03-30 1:52 ` Dan Williams
2024-04-03 15:07 ` Shiyang Ruan via
2024-03-29 6:36 ` [RFC PATCH v2 5/6] cxl: add definition for transaction types Shiyang Ruan via
2024-03-30 1:53 ` Dan Williams
2024-03-29 6:36 ` [RFC PATCH v2 6/6] cxl/core: add poison injection event handler Shiyang Ruan via
2024-03-29 18:27 ` Alison Schofield
2024-03-29 17:43 ` [RFC PATCH v2 0/6] cxl: add poison " Alison Schofield
2024-03-29 18:22 ` Dan Williams
2024-03-29 19:38 ` Alison Schofield
2024-03-29 20:56 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66076d597cd7b_19e029480@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).