From: Richard Henderson <richard.henderson@linaro.org>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: "Kyle Evans" <kevans@freebsd.org>, "Warner Losh" <imp@bsdimp.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-s390x@nongnu.org, "Thomas Huth" <thuth@redhat.com>
Subject: Re: [RFC 2/3] linux-user: Drop uint and ulong
Date: Wed, 10 May 2023 16:04:40 +0100 [thread overview]
Message-ID: <66095dfb-64d1-cb13-c66a-b21d303ae33f@linaro.org> (raw)
In-Reply-To: <20230510143925.4094-3-quintela@redhat.com>
On 5/10/23 15:39, Juan Quintela wrote:
> static bool can_passthrough_madvise(abi_ulong start, abi_ulong end)
> {
> - ulong addr;
> + unsigned long addr;
This should be abi_ulong, to match the parameters.
Which should matter for 32-bit host and 64-bit guest.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-05-10 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 14:39 [RFC 0/3] Getting rid of "uint" and friends Juan Quintela
2023-05-10 14:39 ` [RFC 1/3] ARM: Use normal types Juan Quintela
2023-05-10 15:02 ` Richard Henderson
2023-05-15 16:44 ` Warner Losh
2023-05-15 16:46 ` Warner Losh
2023-05-15 16:56 ` Juan Quintela
2023-05-10 14:39 ` [RFC 2/3] linux-user: Drop uint and ulong Juan Quintela
2023-05-10 15:04 ` Richard Henderson [this message]
2023-05-10 15:12 ` Juan Quintela
2023-05-10 14:39 ` [RFC 3/3] s390-ccw: Getting rid of ulong Juan Quintela
2023-05-25 7:00 ` Thomas Huth
2023-05-10 15:11 ` [RFC 0/3] Getting rid of "uint" and friends Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66095dfb-64d1-cb13-c66a-b21d303ae33f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).