* [PATCH 0/2] Add drive-backed EEPROM support to quanta-q71l
@ 2025-09-16 17:50 Yubin Zou
2025-09-16 17:50 ` [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board Yubin Zou
2025-09-16 17:50 ` [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l Yubin Zou
0 siblings, 2 replies; 10+ messages in thread
From: Yubin Zou @ 2025-09-16 17:50 UTC (permalink / raw)
To: qemu-devel
Cc: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee,
Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Yubin Zou,
Patrick Venture
Overview of Changes:
This two-patch series introduces I2C EEPROM devices (AT24C64) to the
quanta-q71l machine model, representing the Baseboard, Frontpanel,
BIOS, PDB, and BMC FRUs.
Improvement to QEMU:
These changes enhance the simulation fidelity of the quanta-q71l board.
By modeling the FRU EEPROMs and allowing them to be backed by drives.
Impact (Before/After):
Before:
The quanta-q71l machine model did not include the I2C EEPROMs for FRU
data storage.
After:
The EEPROMs are added to the appropriate I2C buses at their respective
addresses. Each eeprom now can be associated with a QEMU driver backend
by using the `-drive`option.
Signed-off-by: Yubin Zou <yubinz@google.com>
---
Patrick Venture (2):
hw/arm: add eeproms to quanta-q7l1 board
hw/arm: enable eeproms for quanta-q71l
hw/arm/aspeed.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
---
base-commit: 190d5d7fd725ff754f94e8e0cbfb69f279c82b5d
change-id: 20250916-quanta-q71l-eeproms-0ebc6e0486d7
Best regards,
--
Yubin Zou <yubinz@google.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board 2025-09-16 17:50 [PATCH 0/2] Add drive-backed EEPROM support to quanta-q71l Yubin Zou @ 2025-09-16 17:50 ` Yubin Zou 2025-09-17 6:10 ` Cédric Le Goater 2025-09-16 17:50 ` [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l Yubin Zou 1 sibling, 1 reply; 10+ messages in thread From: Yubin Zou @ 2025-09-16 17:50 UTC (permalink / raw) To: qemu-devel Cc: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Yubin Zou, Patrick Venture From: Patrick Venture <venture@google.com> Adds eeprom init for aspeed helper method and adds 24c64 eeproms to the quanta-q71l bmc board. Tested: Booted quanta-q71l bmc firmware to userspace. Signed-off-by: Patrick Venture <venture@google.com> --- hw/arm/aspeed.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c31bbe7701381f6980e874f9fca51805ff9fb9b4..bae59ae7394882e3fc93863049a37ff5a8737ff8 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -561,14 +561,17 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4e); i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4f); - /* TODO: i2c-1: Add baseboard FRU eeprom@54 24c64 */ - /* TODO: i2c-1: Add Frontpanel FRU eeprom@57 24c64 */ + /* Baseboard FRU */ + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); + /* Frontpanel FRU */ + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); /* TODO: Add Memory Riser i2c mux and eeproms. */ i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9546", 0x74); i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9548", 0x77); - /* TODO: i2c-3: Add BIOS FRU eeprom@56 24c64 */ + /* Add BIOS FRU */ + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); /* i2c-7 */ i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), "pca9546", 0x70); @@ -577,8 +580,10 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) /* - i2c@2: pmbus@58 */ /* - i2c@3: pmbus@59 */ - /* TODO: i2c-7: Add PDB FRU eeprom@52 */ - /* TODO: i2c-8: Add BMC FRU eeprom@50 */ + /* PDB FRU */ + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); + /* BMC FRU */ + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); } static void ast2500_evb_i2c_init(AspeedMachineState *bmc) -- 2.51.0.384.g4c02a37b29-goog ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board 2025-09-16 17:50 ` [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board Yubin Zou @ 2025-09-17 6:10 ` Cédric Le Goater 2025-09-30 19:25 ` Yubin Zou 0 siblings, 1 reply; 10+ messages in thread From: Cédric Le Goater @ 2025-09-17 6:10 UTC (permalink / raw) To: Yubin Zou, qemu-devel Cc: Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture Hi, On 9/16/25 19:50, Yubin Zou wrote: > From: Patrick Venture <venture@google.com> > > Adds eeprom init for aspeed helper method and adds 24c64 eeproms to the > quanta-q71l bmc board. > > Tested: Booted quanta-q71l bmc firmware to userspace. Could you please provide a FW image and functional test for the quanta-q7l1 board ? Thanks, C. > Signed-off-by: Patrick Venture <venture@google.com> > --- > hw/arm/aspeed.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index c31bbe7701381f6980e874f9fca51805ff9fb9b4..bae59ae7394882e3fc93863049a37ff5a8737ff8 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -561,14 +561,17 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4e); > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4f); > > - /* TODO: i2c-1: Add baseboard FRU eeprom@54 24c64 */ > - /* TODO: i2c-1: Add Frontpanel FRU eeprom@57 24c64 */ > + /* Baseboard FRU */ > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); > + /* Frontpanel FRU */ > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9546", 0x74); > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9548", 0x77); > > - /* TODO: i2c-3: Add BIOS FRU eeprom@56 24c64 */ > + /* Add BIOS FRU */ > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); > > /* i2c-7 */ > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), "pca9546", 0x70); > @@ -577,8 +580,10 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > /* - i2c@2: pmbus@58 */ > /* - i2c@3: pmbus@59 */ > > - /* TODO: i2c-7: Add PDB FRU eeprom@52 */ > - /* TODO: i2c-8: Add BMC FRU eeprom@50 */ > + /* PDB FRU */ > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); > + /* BMC FRU */ > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); > } > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board 2025-09-17 6:10 ` Cédric Le Goater @ 2025-09-30 19:25 ` Yubin Zou 2025-09-30 20:14 ` Cédric Le Goater 0 siblings, 1 reply; 10+ messages in thread From: Yubin Zou @ 2025-09-30 19:25 UTC (permalink / raw) To: Cédric Le Goater Cc: qemu-devel, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture [-- Attachment #1: Type: text/plain, Size: 2662 bytes --] Hi Cedric Could you clarify what functional test you are referring to? Thanks Yubin On Tue, Sep 16, 2025 at 11:10 PM Cédric Le Goater <clg@kaod.org> wrote: > Hi, > > On 9/16/25 19:50, Yubin Zou wrote: > > From: Patrick Venture <venture@google.com> > > > > Adds eeprom init for aspeed helper method and adds 24c64 eeproms to the > > quanta-q71l bmc board. > > > > Tested: Booted quanta-q71l bmc firmware to userspace. > > Could you please provide a FW image and functional test for the > quanta-q7l1 board ? > > Thanks, > > C. > > > > Signed-off-by: Patrick Venture <venture@google.com> > > --- > > hw/arm/aspeed.c | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > > index > c31bbe7701381f6980e874f9fca51805ff9fb9b4..bae59ae7394882e3fc93863049a37ff5a8737ff8 > 100644 > > --- a/hw/arm/aspeed.c > > +++ b/hw/arm/aspeed.c > > @@ -561,14 +561,17 @@ static void > quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), > "tmp105", 0x4e); > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), > "tmp105", 0x4f); > > > > - /* TODO: i2c-1: Add baseboard FRU eeprom@54 24c64 */ > > - /* TODO: i2c-1: Add Frontpanel FRU eeprom@57 24c64 */ > > + /* Baseboard FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); > > + /* Frontpanel FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); > > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), > "pca9546", 0x74); > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), > "pca9548", 0x77); > > > > - /* TODO: i2c-3: Add BIOS FRU eeprom@56 24c64 */ > > + /* Add BIOS FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); > > > > /* i2c-7 */ > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), > "pca9546", 0x70); > > @@ -577,8 +580,10 @@ static void > quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > /* - i2c@2: pmbus@58 */ > > /* - i2c@3: pmbus@59 */ > > > > - /* TODO: i2c-7: Add PDB FRU eeprom@52 */ > > - /* TODO: i2c-8: Add BMC FRU eeprom@50 */ > > + /* PDB FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); > > + /* BMC FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); > > } > > > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > > > > [-- Attachment #2: Type: text/html, Size: 3670 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board 2025-09-30 19:25 ` Yubin Zou @ 2025-09-30 20:14 ` Cédric Le Goater 0 siblings, 0 replies; 10+ messages in thread From: Cédric Le Goater @ 2025-09-30 20:14 UTC (permalink / raw) To: Yubin Zou Cc: qemu-devel, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture Hello Yubin, On 9/30/25 21:25, Yubin Zou wrote: > Hi Cedric > > Could you clarify what functional test you are referring to? It's a small python test downloading a FW image and booting the machine, possibly also testing that expected services are up and running, network, I2C devices, etc. This last part is optional. See the test_aspeed_*.py files under : https://gitlab.com/qemu-project/qemu/-/tree/master/tests/functional/arm?ref_type=heads test_aspeed_bletchley.py is minimum test_aspeed_ast2600.py is complex Thanks, C. > > Thanks > Yubin > > On Tue, Sep 16, 2025 at 11:10 PM Cédric Le Goater <clg@kaod.org <mailto:clg@kaod.org>> wrote: > > Hi, > > On 9/16/25 19:50, Yubin Zou wrote: > > From: Patrick Venture <venture@google.com <mailto:venture@google.com>> > > > > Adds eeprom init for aspeed helper method and adds 24c64 eeproms to the > > quanta-q71l bmc board. > > > > Tested: Booted quanta-q71l bmc firmware to userspace. > > Could you please provide a FW image and functional test for the > quanta-q7l1 board ? > > Thanks, > > C. > > > > Signed-off-by: Patrick Venture <venture@google.com <mailto:venture@google.com>> > > --- > > hw/arm/aspeed.c | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > > index c31bbe7701381f6980e874f9fca51805ff9fb9b4..bae59ae7394882e3fc93863049a37ff5a8737ff8 100644 > > --- a/hw/arm/aspeed.c > > +++ b/hw/arm/aspeed.c > > @@ -561,14 +561,17 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4e); > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4f); > > > > - /* TODO: i2c-1: Add baseboard FRU eeprom@54 24c64 */ > > - /* TODO: i2c-1: Add Frontpanel FRU eeprom@57 24c64 */ > > + /* Baseboard FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); > > + /* Frontpanel FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); > > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9546", 0x74); > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9548", 0x77); > > > > - /* TODO: i2c-3: Add BIOS FRU eeprom@56 24c64 */ > > + /* Add BIOS FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); > > > > /* i2c-7 */ > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), "pca9546", 0x70); > > @@ -577,8 +580,10 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > /* - i2c@2: pmbus@58 */ > > /* - i2c@3: pmbus@59 */ > > > > - /* TODO: i2c-7: Add PDB FRU eeprom@52 */ > > - /* TODO: i2c-8: Add BMC FRU eeprom@50 */ > > + /* PDB FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); > > + /* BMC FRU */ > > + at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); > > } > > > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l 2025-09-16 17:50 [PATCH 0/2] Add drive-backed EEPROM support to quanta-q71l Yubin Zou 2025-09-16 17:50 ` [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board Yubin Zou @ 2025-09-16 17:50 ` Yubin Zou 2025-09-17 6:07 ` Cédric Le Goater 1 sibling, 1 reply; 10+ messages in thread From: Yubin Zou @ 2025-09-16 17:50 UTC (permalink / raw) To: qemu-devel Cc: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Yubin Zou, Patrick Venture From: Patrick Venture <venture@google.com> Tested: Quanta-q71l firmware booted to login and was populated via the -drives for the corresponding eeproms. Signed-off-by: Patrick Venture <venture@google.com> --- hw/arm/aspeed.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index bae59ae7394882e3fc93863049a37ff5a8737ff8..8cef387a0b431576a873553704920886222cca86 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -562,16 +562,16 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4f); /* Baseboard FRU */ - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x54, 8192, 0); /* Frontpanel FRU */ - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x57, 8192, 1); /* TODO: Add Memory Riser i2c mux and eeproms. */ i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9546", 0x74); i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9548", 0x77); /* Add BIOS FRU */ - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 3), 3, 0x56, 8192, 2); /* i2c-7 */ i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), "pca9546", 0x70); @@ -581,9 +581,9 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) /* - i2c@3: pmbus@59 */ /* PDB FRU */ - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 7, 0x52, 8192, 3); /* BMC FRU */ - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 8, 0x50, 8192, 4); } static void ast2500_evb_i2c_init(AspeedMachineState *bmc) -- 2.51.0.384.g4c02a37b29-goog ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l 2025-09-16 17:50 ` [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l Yubin Zou @ 2025-09-17 6:07 ` Cédric Le Goater 2025-09-30 22:17 ` Yubin Zou 0 siblings, 1 reply; 10+ messages in thread From: Cédric Le Goater @ 2025-09-17 6:07 UTC (permalink / raw) To: Yubin Zou, qemu-devel Cc: Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture Hi, On 9/16/25 19:50, Yubin Zou wrote: > From: Patrick Venture <venture@google.com> > > Tested: Quanta-q71l firmware booted to login and was populated via the > -drives for the corresponding eeproms. > Signed-off-by: Patrick Venture <venture@google.com> > --- > hw/arm/aspeed.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index bae59ae7394882e3fc93863049a37ff5a8737ff8..8cef387a0b431576a873553704920886222cca86 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -562,16 +562,16 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4f); > > /* Baseboard FRU */ > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x54, 8192, 0); Where is at24c_eeprom_init_one() implementation ? Thanks, C. > /* Frontpanel FRU */ > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x57, 8192, 1); > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9546", 0x74); > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9548", 0x77); > > /* Add BIOS FRU */ > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 3), 3, 0x56, 8192, 2); > > /* i2c-7 */ > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), "pca9546", 0x70); > @@ -581,9 +581,9 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > /* - i2c@3: pmbus@59 */ > > /* PDB FRU */ > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 7, 0x52, 8192, 3); > /* BMC FRU */ > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 8, 0x50, 8192, 4); > } > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l 2025-09-17 6:07 ` Cédric Le Goater @ 2025-09-30 22:17 ` Yubin Zou 2025-11-11 18:26 ` Cédric Le Goater 0 siblings, 1 reply; 10+ messages in thread From: Yubin Zou @ 2025-09-30 22:17 UTC (permalink / raw) To: Cédric Le Goater Cc: qemu-devel, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture [-- Attachment #1: Type: text/plain, Size: 2606 bytes --] Yes, I will include the patch containing the utility function of at24c_eeprom_init_one. Yubin On Tue, Sep 16, 2025 at 11:07 PM Cédric Le Goater <clg@kaod.org> wrote: > Hi, > > On 9/16/25 19:50, Yubin Zou wrote: > > From: Patrick Venture <venture@google.com> > > > > Tested: Quanta-q71l firmware booted to login and was populated via the > > -drives for the corresponding eeproms. > > Signed-off-by: Patrick Venture <venture@google.com> > > --- > > hw/arm/aspeed.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > > index > bae59ae7394882e3fc93863049a37ff5a8737ff8..8cef387a0b431576a873553704920886222cca86 > 100644 > > --- a/hw/arm/aspeed.c > > +++ b/hw/arm/aspeed.c > > @@ -562,16 +562,16 @@ static void > quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), > "tmp105", 0x4f); > > > > /* Baseboard FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x54, > 8192, 0); > > Where is at24c_eeprom_init_one() implementation ? > > > Thanks, > > C. > > > > /* Frontpanel FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x57, > 8192, 1); > > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), > "pca9546", 0x74); > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), > "pca9548", 0x77); > > > > /* Add BIOS FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 3), 3, 0x56, > 8192, 2); > > > > /* i2c-7 */ > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), > "pca9546", 0x70); > > @@ -581,9 +581,9 @@ static void > quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > /* - i2c@3: pmbus@59 */ > > > > /* PDB FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 7, 0x52, > 8192, 3); > > /* BMC FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 8, 0x50, > 8192, 4); > > } > > > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > > > > [-- Attachment #2: Type: text/html, Size: 3496 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l 2025-09-30 22:17 ` Yubin Zou @ 2025-11-11 18:26 ` Cédric Le Goater 2025-11-13 0:44 ` Yubin Zou 0 siblings, 1 reply; 10+ messages in thread From: Cédric Le Goater @ 2025-11-11 18:26 UTC (permalink / raw) To: Yubin Zou Cc: qemu-devel, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture Hi, On 10/1/25 00:17, Yubin Zou wrote: > Yes, I will include the patch containing the utility function of at24c_eeprom_init_one. Will you send an update or have you given up on the idea ? Thanks, C. > > Yubin > > On Tue, Sep 16, 2025 at 11:07 PM Cédric Le Goater <clg@kaod.org <mailto:clg@kaod.org>> wrote: > > Hi, > > On 9/16/25 19:50, Yubin Zou wrote: > > From: Patrick Venture <venture@google.com <mailto:venture@google.com>> > > > > Tested: Quanta-q71l firmware booted to login and was populated via the > > -drives for the corresponding eeproms. > > Signed-off-by: Patrick Venture <venture@google.com <mailto:venture@google.com>> > > --- > > hw/arm/aspeed.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > > index bae59ae7394882e3fc93863049a37ff5a8737ff8..8cef387a0b431576a873553704920886222cca86 100644 > > --- a/hw/arm/aspeed.c > > +++ b/hw/arm/aspeed.c > > @@ -562,16 +562,16 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x4f); > > > > /* Baseboard FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x54, 8192, 0); > > Where is at24c_eeprom_init_one() implementation ? > > > Thanks, > > C. > > > > /* Frontpanel FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, 0x57, 8192, 1); > > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9546", 0x74); > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), "pca9548", 0x77); > > > > /* Add BIOS FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 3), 3, 0x56, 8192, 2); > > > > /* i2c-7 */ > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), "pca9546", 0x70); > > @@ -581,9 +581,9 @@ static void quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > /* - i2c@3: pmbus@59 */ > > > > /* PDB FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 7, 0x52, 8192, 3); > > /* BMC FRU */ > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, 8192); > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 8, 0x50, 8192, 4); > > } > > > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l 2025-11-11 18:26 ` Cédric Le Goater @ 2025-11-13 0:44 ` Yubin Zou 0 siblings, 0 replies; 10+ messages in thread From: Yubin Zou @ 2025-11-13 0:44 UTC (permalink / raw) To: Cédric Le Goater Cc: qemu-devel, Peter Maydell, Steven Lee, Troy Lee, Jamin Lin, Andrew Jeffery, Joel Stanley, qemu-arm, Patrick Venture [-- Attachment #1: Type: text/plain, Size: 3460 bytes --] Hi Thanks for reminding me. I have updated the series to include the utility function of at24c_eeprom_init_one. Thanks On Tue, Nov 11, 2025 at 10:26 AM Cédric Le Goater <clg@kaod.org> wrote: > Hi, > > On 10/1/25 00:17, Yubin Zou wrote: > > Yes, I will include the patch containing the utility function of > at24c_eeprom_init_one. > > Will you send an update or have you given up on the idea ? > > > Thanks, > > C. > > > > > > Yubin > > > > On Tue, Sep 16, 2025 at 11:07 PM Cédric Le Goater <clg@kaod.org <mailto: > clg@kaod.org>> wrote: > > > > Hi, > > > > On 9/16/25 19:50, Yubin Zou wrote: > > > From: Patrick Venture <venture@google.com <mailto: > venture@google.com>> > > > > > > Tested: Quanta-q71l firmware booted to login and was populated > via the > > > -drives for the corresponding eeproms. > > > Signed-off-by: Patrick Venture <venture@google.com <mailto: > venture@google.com>> > > > --- > > > hw/arm/aspeed.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > > > index > bae59ae7394882e3fc93863049a37ff5a8737ff8..8cef387a0b431576a873553704920886222cca86 > 100644 > > > --- a/hw/arm/aspeed.c > > > +++ b/hw/arm/aspeed.c > > > @@ -562,16 +562,16 @@ static void > quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), > "tmp105", 0x4f); > > > > > > /* Baseboard FRU */ > > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x54, > 8192); > > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, > 0x54, 8192, 0); > > > > Where is at24c_eeprom_init_one() implementation ? > > > > > > Thanks, > > > > C. > > > > > > > /* Frontpanel FRU */ > > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 1), 0x57, > 8192); > > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 1), 1, > 0x57, 8192, 1); > > > /* TODO: Add Memory Riser i2c mux and eeproms. */ > > > > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), > "pca9546", 0x74); > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 2), > "pca9548", 0x77); > > > > > > /* Add BIOS FRU */ > > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 3), 0x56, > 8192); > > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 3), 3, > 0x56, 8192, 2); > > > > > > /* i2c-7 */ > > > i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), > "pca9546", 0x70); > > > @@ -581,9 +581,9 @@ static void > quanta_q71l_bmc_i2c_init(AspeedMachineState *bmc) > > > /* - i2c@3: pmbus@59 */ > > > > > > /* PDB FRU */ > > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 7), 0x52, > 8192); > > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 7, > 0x52, 8192, 3); > > > /* BMC FRU */ > > > - at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50, > 8192); > > > + at24c_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 8, > 0x50, 8192, 4); > > > } > > > > > > static void ast2500_evb_i2c_init(AspeedMachineState *bmc) > > > > > > > [-- Attachment #2: Type: text/html, Size: 4957 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-11-13 0:45 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-09-16 17:50 [PATCH 0/2] Add drive-backed EEPROM support to quanta-q71l Yubin Zou 2025-09-16 17:50 ` [PATCH 1/2] hw/arm: add eeproms to quanta-q7l1 board Yubin Zou 2025-09-17 6:10 ` Cédric Le Goater 2025-09-30 19:25 ` Yubin Zou 2025-09-30 20:14 ` Cédric Le Goater 2025-09-16 17:50 ` [PATCH 2/2] hw/arm: enable eeproms for quanta-q71l Yubin Zou 2025-09-17 6:07 ` Cédric Le Goater 2025-09-30 22:17 ` Yubin Zou 2025-11-11 18:26 ` Cédric Le Goater 2025-11-13 0:44 ` Yubin Zou
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).