From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E162C04FFE for ; Tue, 23 Apr 2024 17:36:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzK3J-00073f-6j; Tue, 23 Apr 2024 13:35:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzK3G-00073U-JF for qemu-devel@nongnu.org; Tue, 23 Apr 2024 13:35:30 -0400 Received: from mgamail.intel.com ([192.198.163.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzK3D-00048O-Qq for qemu-devel@nongnu.org; Tue, 23 Apr 2024 13:35:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713893728; x=1745429728; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=BMTZ99o4N5xnfpCSa4gNpBFqIl+Ehf9Zj28W9lRI1As=; b=QPWSicIXXLrVWoXqjjhRhFCh8J2s3Zrtq11fLMKZZJTUi/YN/yGjO0JC pFUlSgYv1gkhsUunfn6LGC8gheIpXULvT0Pgmh07JE3I8hiAReS+iFIOO QPCJVuYZ5Hs5OQwj+uQ4UsB2+I+Ur7duHcfWizZjz4fxNY73xBYLfLp6O uYQUe+v06F3oIyD9f5bazEPF78vOfzeJJOLJbkWdCWkpSQ8ogJdaiqUgg vlJTwn8E0Iuy7LXyrgzu1NChJnqwC2XhVuy2bFNp9O/aN6+9P4VEUmwvp XgwQob8yfE7elJunLKsJTbzni2FQlfAXplSf/TXPMWPcuGXcruvzAvJSo w==; X-CSE-ConnectionGUID: cYBW5p/ISnGfTvUu6od6sA== X-CSE-MsgGUID: KivsJPdXRbqipoqfPRrifg== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9712139" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9712139" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 10:35:24 -0700 X-CSE-ConnectionGUID: mTyQ/0hgTcu0C2lCl89LzQ== X-CSE-MsgGUID: PJk5134DQ6O2ZJrVKtgscA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="29096759" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Apr 2024 10:35:24 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 10:35:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Apr 2024 10:35:23 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Apr 2024 10:35:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dk7g7iavDx3AFSZieDD7U0PY4T7DnFULQQohtCdyRVGtwpirNLotvxhQLZQFIJHlmq0O9VvroKJMTxNkrFlj8U2ZGdUVMp8krOYYwz/+Ay+BTPOe+zu91izumOXd8hV9e7JukqnXM1BMMeX1zGJt5eLnIbA8A/rcFRMU7Ij3EO96mHRneMJt01Em+r5pi+E6hOMbK+FYzz3ogYuuZLP9gpujO9B8uSvIaJq9+R895S9hozYB8uDibFl8K7r+NHQdjMfh5YyPd0FKUeJUCpfd5bj7WUDMB8xXp7P0h6Yg3HGG9wEt5ipR0FHYoN3mCM58gv4M/LhIZl/M/WI9+h3vbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uBtPykkE4Tlk7wV7VwG2EykluVTDIxe8vbGmo56puvA=; b=S7puGjPC5A+tJ22DEuEJByZs7EfZabjSscAM1utSUWCOxUHUV/Xpx/tdWAyfJeBMqOI+2pLbeSve/YqT3ePE7lK+qZXwwJgFjdUP+7jThu1tzjBhI8u+kJH1KcXkrdBc3j0sDZkipUxGiBd3fgRZ0ahAaov50ashQbrnZdH/MJFeHd0NapeOnpe0ht0S2xAKkAlespggzeQY2vS5/w3mfoKTiMN1qQ5EZls+9afsyxbKl49huFarCM7EJME5wHUhySDxTkqIZWT7p19lKK39dZKE0H4CE0EEEOGS5rSXVqc4VsXvF/1FL5Sizwt4GLWnc8EGcQv3M3mhHntxaFXgGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) by MN0PR11MB6184.namprd11.prod.outlook.com (2603:10b6:208:3c4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Tue, 23 Apr 2024 17:35:19 +0000 Received: from SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::d543:d6c2:6eee:4ec]) by SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::d543:d6c2:6eee:4ec%4]) with mapi id 15.20.7519.020; Tue, 23 Apr 2024 17:35:19 +0000 Date: Tue, 23 Apr 2024 10:35:16 -0700 From: Ira Weiny To: Shiyang Ruan , , CC: , , , , , Subject: Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks Message-ID: <6627f1544e5ab_cd8e02944e@iweiny-mobl.notmuch> References: <20240417075053.3273543-1-ruansy.fnst@fujitsu.com> <20240417075053.3273543-2-ruansy.fnst@fujitsu.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240417075053.3273543-2-ruansy.fnst@fujitsu.com> X-ClientProxiedBy: BYAPR07CA0025.namprd07.prod.outlook.com (2603:10b6:a02:bc::38) To SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB6733:EE_|MN0PR11MB6184:EE_ X-MS-Office365-Filtering-Correlation-Id: 1174435b-e93b-4e2f-0c95-08dc63bbbe9e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YDTl58sJNVJO/bwbJhoGJHapoPciEwWwFFXd5gKCihMOppKQBwafh1SNtCkY?= =?us-ascii?Q?93dzxe872PW0Sv2SrVUQqYZ9OzIMHl2UdZbomfK3NoaTG/kuZjExTCIMSVjk?= =?us-ascii?Q?HXPVto2iKXQyzN3obNytBhH6yRYlR4JSj0A1Gfy+DEU39azg1u7f0JKgRO5T?= =?us-ascii?Q?vgL56CKZ9Ayzd2BPGJA3cwPqId8a8/cSwqZfU773tVoM0KJamWEs0T3ulv64?= =?us-ascii?Q?FC/lS3reWEFDH3oES5/aniJPGCmJFkxAZdiYM7bBhXYumVx1LNhX4puSLNKP?= =?us-ascii?Q?rfG+gupji0eF6ZNapRcRbyGeca+/L/p73bQrTD06CFAxKQ4telwZSHXLZk3u?= =?us-ascii?Q?DexLc5ZAMck/4WZpSyXBRUKTkMcuM5XPjbmn0APPyh1RcQv145K6H1tROQa8?= =?us-ascii?Q?Jq600LFXoHa55XjlTl+iv9RuEMLip+FkxcKxZe/2PmKC4PlYi6+FjMKnHqkw?= =?us-ascii?Q?BYMTNvcgYLq04lxmkqvL4gvVd9HNiE9+bP7fZADPydasiOCxA4td4+9SMuQ7?= =?us-ascii?Q?m3TdBoLedaGftpO/mFwme+Wr4uzTaYid8HtCHACFtnVxJkx2DcJ2o7uioHoC?= =?us-ascii?Q?MIRCQgiU0JPPQQOUqAX7UvolPv0GO3N6G1outFqakMamQr10/ko/Aw/rMAJ/?= =?us-ascii?Q?7Aq98BWFzCxUM2MZ8rIwUqyEu5eR2YS3E2XaNn7a89I7NuO66Q868LT2IG4f?= =?us-ascii?Q?jFonl8QuhVKc6h0WRzgke8vhvJ0GcFDzF2M9M7gwzaDXOggOKUW6o/sa8W/d?= =?us-ascii?Q?E2asEhWy0KHW5Q8paeta40j2d9BKDnoljDwpPXP3/rnmWY8rQRCv5ElTU2iL?= =?us-ascii?Q?j2M9OwW2nwT6D00T+8uThW8u1YwWfh3mYZqoH6324RR4v/RxWo73lhaOf7tY?= =?us-ascii?Q?IL2iyDfDVrqc5QTxMzr4NPMlGEKrQIPLZRorABo/Ag5zTO4t11G2XkXWTj7m?= =?us-ascii?Q?uTJfljlV/jDGVM5CXheEMJBHVMl+MOXf/0OG0uqFh9U5Dueebg1BfhwhLiFk?= =?us-ascii?Q?Gi+/dcqDJapugXYvM3V+c/Vyiqj9qXnjn+/m4U6V89aIJ+thA/+lu2elUXEJ?= =?us-ascii?Q?UNpLSo30AvaiHVOpLmsDEwDtzCvkPhL5uxzAhY9+etrtYyOJDzr4S/uohzER?= =?us-ascii?Q?8KevU+AFLuD7DH0McTDuAnw4gUiGOv1GaxZCZI/6TG03EWW0IP6meR9Ql+z3?= =?us-ascii?Q?A9V2XlhAm+2zA9G7V/pBMTK24chD1AV6xw6WumR/ycnYQdQTIiUBgmy3x9tS?= =?us-ascii?Q?Bh+eXsrWIJZD8q1g1C6BUtnEeHY5TLKPBU0ZUjEUZQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB6733.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HKCb6XR8QkJDUpCWl2Ul61nfLGyjqG3RVYzz1DnHlkHD8tR0zZZJN8sFvW1I?= =?us-ascii?Q?y2+tAgmTNCMeKyFGZTEfkp6DlRxkaxejTyYJHOXcZU8NKOOPDfE2ZLDosK/B?= =?us-ascii?Q?hf81VbGVOHW31Qjjq4evtOWEBJGovn8DJNEnzGkK6XhUE0I2FcR9/EgEcGR5?= =?us-ascii?Q?Mj/3O8BVJgvFIhw8kMu/VTC6VWtW6akP7+R5SDXJF/Yq1CHZDuHGS2aNNDSO?= =?us-ascii?Q?qJuovgXafAYWZSKwNa/eSt8OJxK8IGTY44jKqK6JDoSj4ELb6Jzmhj60M1jA?= =?us-ascii?Q?Me7S4HqI6w9OLQT9EFWt7mxw0/Ciwe8uvAQMl6x01C+86G+EqJvz6UVAvvw2?= =?us-ascii?Q?XlCgOoA4mt5yWAOGdO4Y9MEQwoWS6zHLeGFaFoIVJyJkpPvMJQDTU40qZXkN?= =?us-ascii?Q?fhVASvlmpW9ZNsFHSXqkS4LvYZokHoULunptRENf4TrAiMGsIAqFs2HjHTga?= =?us-ascii?Q?DEIAETUd369clNc3PX6aIrZv8dwa23K9r4z+92MEorph/QkCNn8+wl6kzRK5?= =?us-ascii?Q?x+p0STw5kixWnCSvg1Axzjs6XQMDZj0mTQgLSg8m3TGSz7fYZ68J/IkdfgDG?= =?us-ascii?Q?ify4l0rinnzlSCs8vcEDXS/+OHN5qrG+qawmpopWNQRwJV06g3ieusevwpEe?= =?us-ascii?Q?JscilhuXyDxe2lniNMFawaxjTQacL2sFVEbi+PrshXMhi158RINjxz7FpI9v?= =?us-ascii?Q?WUBgH4CnYpt4CikKBVs6F9qnzzLSIXNBo3Req2/9WT0U173ZYjJdt3BEPkCy?= =?us-ascii?Q?h4QMIOc2imw+TM4mDhCgLg5rOXCnOQ+GypigvEjBqHJtI2BzLlk94wilLmSW?= =?us-ascii?Q?77LthY2wmwRiyxfpNj51W+kaZ/SCqPsR/qOpdrpCX5F1sTUAmrBatWd4Vhru?= =?us-ascii?Q?n8x1GD7VtMF6IclDcyjc6qpsuph+7j0QxKh2Q/0PBUOszHieCKQql5BKejjo?= =?us-ascii?Q?1vdSu3dUV9qq3zmhprkQZlrLWzkxg7R46hKVyOXTIUkmhPZoEs/zN+twa/JU?= =?us-ascii?Q?gm/KcUgBuD7eyCpPege9PGnqDmmZTn+pGff3goi6ggMACLfOKAsnmL7bcsQ5?= =?us-ascii?Q?DPR28kHZfjuzYcjG6AzRdSEaayt3Xegbz0HavsLvFKJ97Af6w3y8UbN6/AJU?= =?us-ascii?Q?rF5Ucikbm5YBzdb/OrRngrRUaIi4yfIYuhlDi0b32FS9ZOrkBXxSzefjF/NA?= =?us-ascii?Q?BHiXas41Q+Pp3Mb0EV4ec7DHjFgfSko6yLK/OdrT11Y2A7V5WsayKSrjzzfR?= =?us-ascii?Q?uYldY4ovKVj0JZoHouOIw4UCCtB7GdFKr3d1gruUk5BpgHNuqsxoq9uheawl?= =?us-ascii?Q?W7EBKfvIbq9pGvmkMM8MGREHzcp8vVH3LdN95yABcooHCPT94p3preTqOtGv?= =?us-ascii?Q?joCDYkENcLMKQu3BwhBpjhLRalxhOpfc7gH/0F5QcjHs9q8out+BCr7T8lIB?= =?us-ascii?Q?r73F7AJotAUZZfbc5K711pRsdHJR5KO1dbpzECGI/iodbQ3yapKiGpeNGd5b?= =?us-ascii?Q?Nd+6+uTHGLiXUyKq0UpTYdLAjMSrzgeEadqfi+ilRg/Lzlder064QvmxHGX1?= =?us-ascii?Q?4CNaRq9qznWV9ZlSi5y4T55bXeD877So51J6B1a0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1174435b-e93b-4e2f-0c95-08dc63bbbe9e X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 17:35:18.9538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wsn8oxD35ozFuQCv5ZYVTmUhY3kk+/qKAKg0SVgA4waVIoG2el/rr8CpyR0P6tWlsuLAAny0dgEuKhJkCfPH4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6184 X-OriginatorOrg: intel.com Received-SPF: pass client-ip=192.198.163.14; envelope-from=ira.weiny@intel.com; helo=mgamail.intel.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.67, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Shiyang Ruan wrote: > The length of Physical Address in General Media Event Record/DRAM Event > Record is 64-bit, so the field mask should be defined as such length. > Otherwise, this causes cxl_general_media and cxl_dram tracepoints to > mask off the upper-32-bits of DPA addresses. The cxl_poison event is > unaffected. > > If userspace was doing its own DPA-to-HPA translation this could lead to > incorrect page retirement decisions, but there is no known consumer > (like rasdaemon) of this event today. > > Fixes: d54a531a430b ("cxl/mem: Trace General Media Event Record") > Cc: > Cc: Dan Williams > Cc: Davidlohr Bueso > Cc: Jonathan Cameron > Cc: Ira Weiny Apologies I thought I saw this go in before. But perhaps it was a different mask. Reviewed-by: Ira Weiny > Signed-off-by: Shiyang Ruan > --- > drivers/cxl/core/trace.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h > index e5f13260fc52..cdfce932d5b1 100644 > --- a/drivers/cxl/core/trace.h > +++ b/drivers/cxl/core/trace.h > @@ -253,7 +253,7 @@ TRACE_EVENT(cxl_generic_event, > * DRAM Event Record > * CXL rev 3.0 section 8.2.9.2.1.2; Table 8-44 > */ > -#define CXL_DPA_FLAGS_MASK 0x3F > +#define CXL_DPA_FLAGS_MASK 0x3FULL > #define CXL_DPA_MASK (~CXL_DPA_FLAGS_MASK) > > #define CXL_DPA_VOLATILE BIT(0) > -- > 2.34.1 >