From: Thomas Huth <thuth@redhat.com>
To: Dinah Baum <dinahbaum123@gmail.com>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>
Subject: Re: [PATCH 1/2] cpu, qapi, target/arm, i386, s390x: Refactor query-cpu-model-expansion
Date: Mon, 13 Mar 2023 08:39:18 +0100 [thread overview]
Message-ID: <66323001-8ed0-2e55-50cd-dc090bdf85d4@redhat.com> (raw)
In-Reply-To: <20230312210624.2326264-2-dinahbaum123@gmail.com>
On 12/03/2023 22.06, Dinah Baum wrote:
> This patch enables 'query-cpu-model-expansion' on all
> architectures. Only architectures that implement
> the command will return results, others will return an
> error message as before.
>
> This patch lays the groundwork for parsing a
> -cpu cpu,help option as specified in
> https://gitlab.com/qemu-project/qemu/-/issues/1480
>
> Signed-off-by: Dinah Baum <dinahbaum123@gmail.com>
> ---
> MAINTAINERS | 1 +
> cpu.c | 20 +++++
> include/exec/cpu-common.h | 8 ++
> qapi/machine-target-common.json | 129 +++++++++++++++++++++++++++++++
> qapi/machine-target.json | 129 +------------------------------
Could you please elaborate in the patch description, why you apparently had
to move lots of code from one file to another? Why is that necessary?
Thomas
next prev parent reply other threads:[~2023-03-13 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 21:06 [PATCH 0/2] *** Enable -cpu <cpu>,help *** Dinah Baum
2023-03-12 21:06 ` [PATCH 1/2] cpu, qapi, target/arm, i386, s390x: Refactor query-cpu-model-expansion Dinah Baum
2023-03-13 7:39 ` Thomas Huth [this message]
2023-03-12 21:06 ` [PATCH 2/2] cpu, qdict, vl: Enable printing options for CPU type Dinah Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66323001-8ed0-2e55-50cd-dc090bdf85d4@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=dinahbaum123@gmail.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=iii@linux.ibm.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).