From: Paolo Bonzini <pbonzini@redhat.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 1/1] vl.c: do not execute trace_init_backends() before daemonizing
Date: Tue, 5 Jan 2021 19:09:36 +0100 [thread overview]
Message-ID: <6637b86c-d0f9-4253-2f04-3ceec1a6edc2@redhat.com> (raw)
In-Reply-To: <20210105180325.536160-1-danielhb413@gmail.com>
On 05/01/21 19:03, Daniel Henrique Barboza wrote:
> + /*
> + * The trace backend must be initialized before daemonizing.
after, not before. :)
With this fixed,
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> + * trace_init_backends() will call st_init(), which will create the
> + * trace thread in the parent, and also register st_flush_trace_buffer()
> + * in atexit(). This function will force the parent to wait for the
> + * writeout thread to finish, which will not occur, and the parent
> + * process will be left in the host.
> + */
> + if (!trace_init_backends()) {
> + exit(1);
> + }
> + trace_init_file();
> +
next prev parent reply other threads:[~2021-01-05 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 18:03 [PATCH 1/1] vl.c: do not execute trace_init_backends() before daemonizing Daniel Henrique Barboza
2021-01-05 18:09 ` Paolo Bonzini [this message]
2021-01-05 18:17 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6637b86c-d0f9-4253-2f04-3ceec1a6edc2@redhat.com \
--to=pbonzini@redhat.com \
--cc=danielhb413@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).