From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object
Date: Wed, 21 Jun 2017 03:40:31 +0200 [thread overview]
Message-ID: <6639c0c3-0db4-d96e-8227-6b5bf169d232@redhat.com> (raw)
In-Reply-To: <d76ab927-ba90-f8d1-000d-b596edeccfcb@twiddle.net>
On 20.06.2017 20:14, Richard Henderson wrote:
> On 06/19/2017 10:52 PM, Thomas Huth wrote:
>> edu.c does not contain any target-specific code, so we can put
>> it into common-obj-y to compile it only once for all targets.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Isn't CONFIG_EDU defined by the target, via pci.conf?
> Would it ever be set generically?
This is about Makefiles, not #defines in C sources ... so if I
understand our build-system correctly, the variable is set for the
Makefiles of the targets that use pci.mak. As far as I see, it gets
compiled correctly here.
And we've got plenty of those common-obj-$(CONFIG_xxx) statements
elsewhere in this file (e.g. for CONFIG_PCI_TESTDEV which is also
declared in default-configs/pci.mak), so this is just normal, no problem
here, as far as I can tell.
Thomas
next prev parent reply other threads:[~2017-06-21 1:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 5:51 [Qemu-devel] [PATCH v3 0/8] Poison some more target-specific defines Thomas Huth
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 1/8] include/exec/poison: Add missing TARGET defines Thomas Huth
2017-06-20 18:05 ` Richard Henderson
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 2/8] include/exec/poison: Mark some CONFIG defines as poisoned, too Thomas Huth
2017-06-20 18:05 ` Richard Henderson
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 3/8] Move CONFIG_KVM related definitions to kvm_i386.h Thomas Huth
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 4/8] include/exec/poison: Mark CONFIG_KVM as poisoned, too Thomas Huth
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 5/8] cpu: Introduce a wrapper for tlb_flush() that can be used in common code Thomas Huth
2017-06-20 18:08 ` Richard Henderson
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 6/8] include/exec/poison: Mark CONFIG_SOFTMMU as poisoned Thomas Huth
2017-06-20 18:10 ` Richard Henderson
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 7/8] Makefile: Move bootdevice.o to common-obj-y Thomas Huth
2017-06-20 5:52 ` [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object Thomas Huth
2017-06-20 18:14 ` Richard Henderson
2017-06-21 1:40 ` Thomas Huth [this message]
2017-06-22 7:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6639c0c3-0db4-d96e-8227-6b5bf169d232@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).