From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,RCVD_ILLEGAL_IP,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F9DC04AB6 for ; Tue, 28 May 2019 07:46:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E63C62075B for ; Tue, 28 May 2019 07:46:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E63C62075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVWoe-0005MC-IV for qemu-devel@archiver.kernel.org; Tue, 28 May 2019 03:46:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVWno-0004pI-Tf for qemu-devel@nongnu.org; Tue, 28 May 2019 03:45:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVWnn-0003Fy-RK for qemu-devel@nongnu.org; Tue, 28 May 2019 03:45:44 -0400 Received: from mga06.intel.com ([134.134.136.31]:23318) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVWnj-00032B-Jx; Tue, 28 May 2019 03:45:39 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 00:45:24 -0700 X-ExtLoop1: 1 Received: from shzintpr02.sh.intel.com (HELO [0.0.0.0]) ([10.239.4.160]) by orsmga001.jf.intel.com with ESMTP; 28 May 2019 00:45:22 -0700 To: Igor Mammedov References: <20190508061726.27631-1-tao3.xu@intel.com> <20190508061726.27631-4-tao3.xu@intel.com> <20190523154743.5fdd4b81@redhat.com> From: Tao Xu Message-ID: <663c8744-78e4-842c-d9e7-91b36ba30d91@intel.com> Date: Tue, 28 May 2019 15:43:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523154743.5fdd4b81@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.31 Subject: Re: [Qemu-devel] [PATCH v4 03/11] numa: move numa global variable numa_info into MachineState X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com, jingqi.liu@intel.com, qemu-devel@nongnu.org, ehabkost@redhat.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23/05/2019 21:47, Igor Mammedov wrote: > On Wed, 8 May 2019 14:17:18 +0800 > Tao Xu wrote: > ... >> diff --git a/hw/arm/boot.c b/hw/arm/boot.c >> index 8ff08814fd..845b737ab9 100644 >> --- a/hw/arm/boot.c >> +++ b/hw/arm/boot.c >> @@ -602,7 +602,7 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info *binfo, >> if (nb_numa_nodes > 0) { >> mem_base = binfo->loader_start; >> for (i = 0; i < nb_numa_nodes; i++) { >> - mem_len = numa_info[i].node_mem; >> + mem_len = ms->numa_state->nodes[i].node_mem; > in 1/11 I've suggested to add nb_numa_nodes, but it might be to add > a pointer to MachineState there. > It would also help to simplify arm_load_dtb later as there are other > bits that we copy to arm_boot_info from MachineState. > Hi Igor, Thank you for your review. I will simplify arm_load_dtb() in the next version of patch and improve the other issues. Tao