From: Eric Blake <eblake@redhat.com>
To: Murilo Opsfelder Araujo <mopsfelder@gmail.com>, qemu-devel@nongnu.org
Cc: "David Gibson" <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Murilo Opsfelder Araujo" <muriloo@linux.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] ppc/pnv: add INITRD_MAX_SIZE constant
Date: Mon, 25 Feb 2019 09:02:57 -0600 [thread overview]
Message-ID: <664222ad-f92f-bbb5-6f6f-dea39b77cc52@redhat.com> (raw)
In-Reply-To: <20190225142407.9477-3-muriloo@linux.ibm.com>
On 2/25/19 8:24 AM, Murilo Opsfelder Araujo wrote:
> The current 0x10000000 value is actually 256MiB, not 128MB as the comment
> suggests. Move it to a constant and fix the comment (no change in the size
> value).
>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> ---
> hw/ppc/pnv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 000707164e..514439db20 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -56,6 +56,7 @@
> #define KERNEL_LOAD_ADDR 0x20000000
> #define KERNEL_MAX_SIZE 0x10000000 /* 256MiB */
> #define INITRD_LOAD_ADDR 0x60000000
> +#define INITRD_MAX_SIZE 0x10000000 /* 256MiB */
Why not #include "qemu/units.h" and spell this:
#define INITRD_MAX_SIZE (256 * MiB)
and so on for the other values?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2019-02-25 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 14:24 [Qemu-devel] [PATCH 0/2] ppc/pnv: increase kernel size limit to 256MiB Murilo Opsfelder Araujo
2019-02-25 14:24 ` [Qemu-devel] [PATCH 1/2] " Murilo Opsfelder Araujo
2019-02-25 14:24 ` [Qemu-devel] [PATCH 2/2] ppc/pnv: add INITRD_MAX_SIZE constant Murilo Opsfelder Araujo
2019-02-25 15:02 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=664222ad-f92f-bbb5-6f6f-dea39b77cc52@redhat.com \
--to=eblake@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=mopsfelder@gmail.com \
--cc=muriloo@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).