qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: ~vlaomao <vlaomao@gmail.com>
Cc: qemu-trivial@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>,
	Dmitry Fleytman <dmitry.fleytman@gmail.com>,
	Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset
Date: Mon, 30 Jan 2023 19:11:24 +0100	[thread overview]
Message-ID: <664ef653-0026-999c-8c68-587c0442df04@vivier.eu> (raw)
In-Reply-To: <167510125533.6740.18222174398575558338-1@git.sr.ht>

Le 30/01/2023 à 18:28, ~vlaomao a écrit :
> From: VlaoMao <vlaomao@gmail.com>
> 
> Changing the address with a subsequent reboot makes this address permanent until the vm is turned off

Missing Signed-off-by.

See https://www.qemu.org/docs/master/devel/submitting-a-patch.html

> ---
>   hw/net/vmxnet3.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 04159c822..695ca2f92 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -1206,6 +1206,8 @@ static void vmxnet3_reset(VMXNET3State *s)
>       s->drv_shmem = 0;
>       s->tx_sop = true;
>       s->skip_current_tx_pkt = false;
> +
> +    vmxnet3_reset_mac(s);
>   }
>   
>   static void vmxnet3_update_rx_mode(VMXNET3State *s)



       reply	other threads:[~2023-01-30 18:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167510125533.6740.18222174398575558338-1@git.sr.ht>
2023-01-30 18:11 ` Laurent Vivier [this message]
2023-01-30 18:58   ` [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset Влад Мао
2023-01-30 19:06 [PATCH qemu 0/1] vmxnet3: MAC address falls to permanent ~vlaomao
2023-01-30 17:28 ` [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset ~vlaomao
2023-01-31 17:50   ` Laurent Vivier
  -- strict thread matches above, loose matches on Subject: below --
2023-01-31 18:20 [PATCH qemu 0/1] MAC address falls to permanent Vlao Mao
2023-01-31 18:20 ` [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset Vlao Mao
2023-01-31 18:23 [PATCH qemu 0/1] MAC address falls to permanent Vlao Mao
2023-01-31 18:23 ` [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset Vlao Mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=664ef653-0026-999c-8c68-587c0442df04@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=dmitry.fleytman@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=vlaomao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).